chore: add trufflehog secret scanning#345
Open
dblane-digicatapult wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
PR Type
Linked tickets
https://digicatapult.atlassian.net/browse/ENG-292
High level description
Enables TruffleHog secret scanning in CI as required by the Secure Software Development Policy V1.1 and Software Engineering Standard Secure Development Policy V1.1.
Detailed description
Appends a standalone
scan-secretsjob to.github/workflows/check-and-test.ymlusing the sharedscan-secrets.ymlreusable workflow.Describe alternatives you've considered
A standalone
scan-secretsjob was considered butenable_trufflehog_action: trueis preferred wherestatic-checks-npmis already present as it avoids adding a redundant job.Operational impact
None — CI-only change.
Additional context
Part of a compliance audit sweep across the digicatapult org (ENG-292).