chore: dependency upgrades (description + in-range + CJS-compatible majors)#28
Merged
Conversation
Replace the terse description with one that conveys the actual workflow (upload build → run flows on real devices → stream results) and notes both the dcd CLI and dcd-mcp MCP server bins for npm discoverability. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Refresh in-range dependency versions and lockfile: - @clack/prompts 1.2.0 → 1.6.0 - @supabase/supabase-js 2.103.3 → 2.108.2 - plist 3.1.0 → 3.1.1 - mocha 11.7.5 → 11.7.6 - prettier 3.8.3 → 3.8.4 - tsx 4.21.0 → 4.22.4 - typescript-eslint 8.59.0 → 8.61.1 - @types/node 25.6.0 → 25.9.4 Held js-yaml at ^4.2.0 (5.0.0 is a breaking major). Major bumps (chalk 5, chai 6, eslint 10, typescript 6, citty 0.2, plist 5, etc.) are intentionally deferred — they need separate review. typecheck, lint (0 errors), build, and all 147 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
riglar
changed the title
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Take on the available major upgrades that work with our CommonJS build (CLI not yet released, so safe to absorb breakage): - typescript 5.9 → 6.0 - eslint 9 → 10, @eslint/js 9 → 10, eslint-plugin-unicorn 64 → 68 - chai 4 → 6, @types/chai 4 → 5 (test-only; runs under tsx/ESM) - @types/node 25 → 26 - js-yaml 4 → 5 (ships a CJS export condition) Fallout fixed: - metadata-extractor: node-stream-zip is `export =`; TS 6 no longer treats `import * as` of an export-assigned class as constructable, so switch to `import StreamZip = require(...)`. - eslint-plugin-unicorn 68 adds preserve-caught-error: attach `cause` to errors rethrown inside catch blocks across gateways/services/utils. - methods.ts: drop a dead `supabaseResult` initializer flagged by the new no-useless-assignment rule. Held back — ESM-only majors incompatible with our CommonJS output (would each require migrating the CLI to ESM): - chalk stays 4.1.2 (v5 ESM-only) - plist stays 3.1.1 (v5 ESM-only) - citty stays 0.1.6 (v0.2 ESM-only) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
riglar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Housekeeping on dependencies + package metadata. No runtime behaviour changes.
1. Improved package description
2. In-range (minor/patch) bumps
@clack/prompts1.6.0 ·@supabase/supabase-js2.108.2 ·plist3.1.1 ·mocha11.7.6 ·prettier3.8.4 ·tsx4.22.4 ·typescript-eslint8.61.1 ·@types/node25.9.43. Major bumps (CJS-compatible)
typescript5.9 → 6.0eslint9 → 10,@eslint/js9 → 10,eslint-plugin-unicorn64 → 68chai4 → 6,@types/chai4 → 5 (test-only; runs under tsx/ESM)js-yaml4 → 5 (ships a CJS export condition)Fallout fixed:
metadata-extractor:node-stream-zipisexport =; TS 6 no longer treatsimport * asof an export-assigned class as constructable → switched toimport = require(...).eslint-plugin-unicorn68 addspreserve-caught-error: attachedcauseto errors rethrown inside catch blocks (gateways/services/utils).methods.ts: removed a deadsupabaseResultinitializer flagged by the newno-useless-assignmentrule.Held back — ESM-only majors
The CLI compiles to CommonJS, and these majors are ESM-only (
require()throwsERR_PACKAGE_PATH_NOT_EXPORTED):chalkstays 4.1.2 (v5 ESM-only)pliststays 3.1.1 (v5 ESM-only)cittystays 0.1.6 (v0.2 ESM-only)These are intentionally deferred to a dedicated ESM-migration PR (planned after the in-flight UI refactor lands), which will convert the package to ESM and bump all three together.
Verification
Validated in an isolated git worktree at the tip commit (clean of unrelated WIP):
pnpm build✓pnpm typecheck✓pnpm lint✓ (0 errors)pnpm test✓ (147 passing)node dist/index.js --version/--help✓🤖 Generated with Claude Code