Skip to content

fix all warnings#155

Merged
DjDeveloperr merged 7 commits into
denodrivers:mainfrom
sigmaSd:ok
May 26, 2025
Merged

fix all warnings#155
DjDeveloperr merged 7 commits into
denodrivers:mainfrom
sigmaSd:ok

Conversation

@sigmaSd

@sigmaSd sigmaSd commented May 25, 2025

Copy link
Copy Markdown
Contributor

This should allow using deno lsp for all files

Comment thread .github/workflows/ci.yml Outdated
@sigmaSd

sigmaSd commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

this error is weird,
image

if I check the same file locally I don't even have the same lines at all, I'm not sure why the file is different locally

@sigmaSd

sigmaSd commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

turns out I'm missing a rebase

@sigmaSd

sigmaSd commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

it should work now, but the ci github action have some temporary problem it seems

@DjDeveloperr DjDeveloperr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@DjDeveloperr DjDeveloperr merged commit 7d7ef31 into denodrivers:main May 26, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants