Conversation
…nto seperate method. Bug fix for water level led on/off
…duration in the GET /water request. Bug fix to only respond with values when sensor does not report ERROR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
DEBUGflag to support over ride of water level check for testingdaysin irrigation toggle calculation forGET /waterresponsesBug Fixes
LOW) on each request of the current level to ensure only the LED that is the current water level is enabled (HIGH)GET /water/irrigateresponse as it's not a valid measurementRefactors
sendIrrigationDuration()to make irrigation duration calculations their own method