[dmt] Validate module.yaml consistency with package.yaml

[diyliv]

Summary

Add cross-validation between module.yaml and package.yaml to ensure both files stay consistent during the migration period:

• Cross-validate name field: module.yaml name must match package.yaml name.
• Cross-validate deckhouse requirement: module.yaml requirements.deckhouse must match package.yaml requirements.deckhouse.constraint.
• Cross-validate kubernetes requirement: module.yaml requirements.kubernetes must match package.yaml requirements.kubernetes.constraint.
• Cross-validate module dependencies: module.yaml flat module map is compared against package.yaml structured mandatory/conditional lists — entries without !optional must be in mandatory, entries with !optional must be in conditional. Both directions are checked.

If developers no longer want to maintain both files, they should delete module.yaml.

Example

Consistent files — no errors:

# module.yaml
name: stronghold
namespace: test
requirements:
  deckhouse: ">= 1.77"
  kubernetes: ">= 1.27"
  modules:
    mandatory-mod: ">= 1.0.0"
    optional-mod: ">= 1.0.0 !optional"

# package.yaml
name: stronghold
apiVersion: v2
requirements:
  deckhouse:
    constraint: ">= 1.77"
  kubernetes:
    constraint: ">= 1.27"
  modules:
    mandatory:
      - name: mandatory-mod
        constraint: ">= 1.0.0"
    conditional:
      - name: optional-mod
        constraint: ">= 1.0.0"

Inconsistent files — errors reported:

# module.yaml
name: stronghold
requirements:
  modules:
    some-module: ">= 1.0.0"         # mandatory here

# package.yaml
name: stronghold
requirements:
  modules:
    conditional:                     # but conditional here
      - name: some-module
        constraint: ">= 1.0.0"

[Copilot]

Pull request overview

Adds a new module linter rule to cross-validate module.yaml against package.yaml during the migration period, helping detect divergence across shared fields and dependency declarations.

Changes:

• Introduce module-package-consistency rule that compares names, platform requirements (Deckhouse/Kubernetes), and module dependencies between module.yaml and package.yaml.
• Add comprehensive unit/integration-style tests for the new consistency rule.
• Wire the rule into the module linter execution path and linter configuration (global + runtime config structs).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/linters/module/rules/module_package_consistency.go	Implements the cross-validation logic between module.yaml and package.yaml.
pkg/linters/module/rules/module_package_consistency_test.go	Adds test coverage for matching/mismatching cases and parse-error behavior.
pkg/linters/module/module.go	Runs the new rule as part of the module linter.
pkg/config/global/global.go	Exposes the new rule in global config mapping (mapstructure).
pkg/config.go	Exposes the new rule in runtime configuration structs.

Comments suppressed due to low confidence (1)

pkg/linters/module/rules/module_package_consistency.go:106

• Same as Deckhouse: if pkg.Requirements == nil, reporting "...constraint is empty" is misleading because the requirements section is missing entirely. Consider a dedicated message for the missing requirements section.

	if pkg.Requirements == nil || pkg.Requirements.Kubernetes.Constraint == "" {
		errorList.Errorf("module.yaml requirements.kubernetes is %q but package.yaml requirements.kubernetes.constraint is empty", module.Requirements.Kubernetes)
		return

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[diyliv]

fixed

[diyliv]

fixed

[diyliv]

fixed

[diyliv]

fixed

[diyliv]

fixed