fix(cli): Skip echo for inline-composed interrupt replies#838
Merged
Conversation
`InterruptAction::Reply` now carries `from_editor` alongside the reply text. The turn coordinator uses it to decide whether to echo the user's message: an editor-composed reply never appeared on the terminal, so it still renders through `render_user_request` (labeled user header + body). An inline-composed reply is already visible in scrollback on the widget's own line, so the coordinator only resets the assistant-header gate via `begin_turn`, without re-printing the text. Previously every `Reply` interrupt rendered a full user header regardless of composing surface, duplicating text the inline widget had already printed. The next assistant chunk still opens with a fresh `── jp` header in both cases. Adds RFD 093 (Inline-First Query Composition), which extends RFD 088 to make bare `jp query` compose in the inline editor by default, with `Ctrl+X` escaping to the external editor and a new `query.compose_in_editor` setting controlling the surface. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InterruptAction::Replynow carriesfrom_editoralongside the reply text. The turn coordinator uses it to decide whether to echo the user's message: an editor-composed reply never appeared on the terminal, so it still renders throughrender_user_request(labeled user header + body). An inline-composed reply is already visible in scrollback on the widget's own line, so the coordinator only resets the assistant-header gate viabegin_turn, without re-printing the text.Previously every
Replyinterrupt rendered a full user header regardless of composing surface, duplicating text the inline widget had already printed. The next assistant chunk still opens with a fresh── jpheader in both cases.Adds RFD 093 (Inline-First Query Composition), which extends RFD 088 to make bare
jp querycompose in the inline editor by default, withCtrl+Xescaping to the external editor and a newquery.compose_in_editorsetting controlling the surface.