Skip to content

Fix 'runPrompt' Including Stale Selected Cards#390

Merged
PauloMFJ merged 1 commit into
datacommonsorg:mainfrom
madebypxlp:paulo/query-selected-cards
Jul 3, 2026
Merged

Fix 'runPrompt' Including Stale Selected Cards#390
PauloMFJ merged 1 commit into
datacommonsorg:mainfrom
madebypxlp:paulo/query-selected-cards

Conversation

@PauloMFJ

@PauloMFJ PauloMFJ commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@PauloMFJ PauloMFJ self-assigned this Jul 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the QueryProvider component by moving the retrieval of selectedShapeIds from the top-level render scope into the specific callback where it is used. Additionally, the dependency array of the hook has been updated to depend on editor instead of selectedShapeIds to prevent unnecessary re-renders. There are no review comments, and I have no feedback to provide.

@nick-nlb nick-nlb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up on this!

@PauloMFJ PauloMFJ merged commit 0425c07 into datacommonsorg:main Jul 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants