Fix 'runPrompt' Including Stale Selected Cards#390
Merged
PauloMFJ merged 1 commit intoJul 3, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the QueryProvider component by moving the retrieval of selectedShapeIds from the top-level render scope into the specific callback where it is used. Additionally, the dependency array of the hook has been updated to depend on editor instead of selectedShapeIds to prevent unnecessary re-renders. There are no review comments, and I have no feedback to provide.
nick-nlb
approved these changes
Jul 2, 2026
nick-nlb
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for following up on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refs: