Skip to content

workflow update for including embeddings as a parallel processing job with aggregation#599

Open
shixiao-coder wants to merge 4 commits into
datacommonsorg:masterfrom
shixiao-coder:update-spanner-ingestion-workflow-for-embeddings
Open

workflow update for including embeddings as a parallel processing job with aggregation#599
shixiao-coder wants to merge 4 commits into
datacommonsorg:masterfrom
shixiao-coder:update-spanner-ingestion-workflow-for-embeddings

Conversation

@shixiao-coder

@shixiao-coder shixiao-coder commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

… with aggregation

Also update the config to read the template config from a Yaml file for embeddings
@codacy-production

codacy-production Bot commented Jun 29, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

🟢 Metrics 12 complexity

Metric Results
Complexity 12

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for embedding generation within the Spanner ingestion workflow, running embedding jobs in parallel with aggregation jobs. It adds configuration loading from a YAML specification file, along with corresponding unit tests and dependencies. The review feedback highlights three critical issues: the HTTP timeout in the Cloud Workflow exceeds the 1800-second limit, the gcsfs dependency is missing for reading GCS paths with pandas, and resolving the embedding spec path relative to the current working directory may fail in Cloud Run.

Comment thread pipeline/workflow/spanner-ingestion-workflow.yaml
Comment thread pipeline/workflow/ingestion-helper/pyproject.toml
Comment thread pipeline/workflow/ingestion-helper/config.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant