Open
Conversation
itholic
commented
Sep 22, 2020
HyukjinKwon
reviewed
Sep 24, 2020
HyukjinKwon
reviewed
Sep 24, 2020
Contributor
Author
|
Thanks, @HyukjinKwon |
ueshin
reviewed
Sep 25, 2020
Contributor
Author
|
Thanks, @ueshin |
HyukjinKwon
reviewed
Sep 29, 2020
| raise ValueError("Row labels must have same size as column labels") | ||
| lookups = [ | ||
| self.loc[row_label, col_label] | ||
| for row_label, col_label in zip(row_labels, col_labels) |
Member
There was a problem hiding this comment.
Does this mean we launch jobs as many as labels?
| self.loc[row_label, col_label] for row_label, col_label in zip(row_labels, col_labels) | ||
| ] | ||
| return Series(lookups).to_numpy() | ||
| return np.asarray(pd.Series(lookups)) |
Contributor
There was a problem hiding this comment.
Out of curiosity, why did we change it to np.asarray(pd.Series(lookups))?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes
DataFrame.lookup.