fix: Clamp section index to prevent out-of-bounds error#2
Open
recynie wants to merge 1 commit into
Open
Conversation
…error When #question is used before any #section is defined, section-counter is 0, causing section index to become -1 and triggering an array index out of bounds error. Use calc.max(..., 0) to guard against this. Fixes data-8#1
There was a problem hiding this comment.
Pull request overview
This PR fixes an out-of-bounds error when point-bearing questions are added before any numbered section exists by clamping the computed section index to zero.
Changes:
- Prevents
add-pointsfrom using-1as an array index whensection-counteris still zero.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
#questionis used before any#sectionis defined, section-counter is0, causing section index to become-1and triggering an array index out of bounds error. Usecalc.max(..., 0)to guard against this.Fixes #1