Skip to content

feat(posts): support scheduling all post types #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idoshamun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(posts): support scheduling all post types #3975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 159 additions & 14 deletions __tests__/posts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import { DataSource, DeepPartial, In, IsNull, Not } from 'typeorm';
import createOrGetConnection from '../src/db';
import {
createSquadWelcomePost,
defaultImage,
DEFAULT_POST_TITLE,
notifyContentRequested,
notifyView,
Expand Down Expand Up @@ -2851,10 +2852,23 @@ describe('mutation reportPost', () => {

describe('mutation sharePost', () => {
const MUTATION = /* GraphQL */ `
mutation SharePost($sourceId: ID!, $id: ID!, $commentary: String) {
sharePost(sourceId: $sourceId, id: $id, commentary: $commentary) {
mutation SharePost(
$sourceId: ID!
$id: ID!
$commentary: String
$scheduledAt: DateTime
) {
sharePost(
sourceId: $sourceId
id: $id
commentary: $commentary
scheduledAt: $scheduledAt
) {
id
titleHtml
flags {
scheduledAt
}
}
}
`;
Expand Down Expand Up @@ -2929,6 +2943,28 @@ describe('mutation sharePost', () => {
expect(post.title).toEqual('My comment');
});

it('should schedule shared post', async () => {
loggedUser = '1';
const scheduledAt = new Date(Date.now() + 60_000).toISOString();
const res = await client.mutate(MUTATION, {
variables: { ...variables, scheduledAt },
});
expect(res.errors).toBeFalsy();
expect(res.data.sharePost.flags.scheduledAt).toEqual(scheduledAt);

const post = await con
.getRepository(SharePost)
.findOneByOrFail({ id: res.data.sharePost.id });
expect(post).toMatchObject({
authorId: '1',
sharedPostId: 'p1',
title: 'My comment',
visible: false,
visibleAt: null,
});
expect(post.flags.scheduledAt).toEqual(scheduledAt);
});

it('should create invisible share and still return mutation result', async () => {
loggedUser = '1';
const res = await client.mutate(MUTATION, {
Expand Down Expand Up @@ -3627,7 +3663,7 @@ describe('mutation createPostInMultipleSources', () => {

it('should throw error when content exceeds maximum length', async () => {
loggedUser = '1';
const longContent = 'a'.repeat(10001); // exceeds 10000 character limit
const longContent = 'a'.repeat(20_001);
return testMutationErrorCode(
client,
{
Expand Down Expand Up @@ -4367,13 +4403,13 @@ describe('post creation', () => {
}: {
mutation: string;
variables: Record<string, unknown>;
assertData: (data: TData) => void;
assertData: (data: TData) => void | Promise<void>;
}): Promise<void> => {
loggedUser = '1';
const res = await client.mutate(mutation, { variables });

expect(res.errors).toBeFalsy();
assertData(res.data as TData);
await assertData(res.data as TData);
};

it('should allow createFreeformPost for incomplete profile', async () => {
Expand Down Expand Up @@ -4470,6 +4506,61 @@ describe('post creation', () => {
});
});

it('should schedule createPollPost for incomplete profile', async () => {
await setupWritableSource('s-scheduled-poll');
const scheduledAt = new Date(Date.now() + 60_000).toISOString();

await expectSuccessfulPostCreation<{
createPollPost: { id: string; flags: { scheduledAt: string } };
}>({
mutation: `
mutation CreatePollPost(
$sourceId: ID!
$title: String!
$options: [PollOptionInput!]!
$duration: Int
$scheduledAt: DateTime
) {
createPollPost(
sourceId: $sourceId
title: $title
options: $options
duration: $duration
scheduledAt: $scheduledAt
) {
id
flags {
scheduledAt
}
}
}
`,
variables: {
sourceId: 's-scheduled-poll',
title: 'Scheduled poll title',
duration: 3,
scheduledAt,
options: [
{ text: 'Option 1', order: 0 },
{ text: 'Option 2', order: 1 },
],
},
assertData: async (data) => {
expect(data.createPollPost.flags.scheduledAt).toEqual(scheduledAt);

const post = await con
.getRepository(PollPost)
.findOneByOrFail({ id: data.createPollPost.id });
expect(post.visible).toBe(false);
expect(post.visibleAt).toBeNull();
expect(post.flags.scheduledAt).toEqual(scheduledAt);
expect(post.endsAt?.toISOString()).toEqual(
addDays(new Date(scheduledAt), 3).toISOString(),
);
},
});
});

it('should allow createPostInMultipleSources for incomplete profile', async () => {
await con.getRepository(SourceMember).save({
userId: '1',
Expand Down Expand Up @@ -4517,13 +4608,15 @@ describe('mutation submitExternalLink', () => {
$commentary: String
$title: String
$image: String
$scheduledAt: DateTime
) {
submitExternalLink(
sourceId: $sourceId
url: $url
commentary: $commentary
title: $title
image: $image
scheduledAt: $scheduledAt
) {
_
}
Expand Down Expand Up @@ -4631,6 +4724,32 @@ describe('mutation submitExternalLink', () => {
await checkSharedPostExpectation(true);
});

it('should schedule external link share', async () => {
loggedUser = '1';
const scheduledAt = new Date(Date.now() + 60_000).toISOString();
const url = 'https://scheduled.daily.dev';
const res = await client.mutate(MUTATION, {
variables: {
...variables,
url,
title: 'Scheduled external link title',
scheduledAt,
},
});
expect(res.errors).toBeFalsy();

const articlePost = await con
.getRepository(ArticlePost)
.findOneByOrFail({ url });
const sharedPost = await con
.getRepository(SharePost)
.findOneByOrFail({ sharedPostId: articlePost.id });

expect(sharedPost.visible).toBe(false);
expect(sharedPost.visibleAt).toBeNull();
expect(sharedPost.flags.scheduledAt).toEqual(scheduledAt);
});

it('should share existing post to squad', async () => {
loggedUser = '1';
const res = await client.mutate(MUTATION, {
Expand Down Expand Up @@ -5375,9 +5494,7 @@ describe('mutation checkLinkPreview', () => {

expect(res.errors).toBeFalsy();
expect(res.data.checkLinkPreview.title).toEqual(sampleResponse.title);
expect(res.data.checkLinkPreview.image).toEqual(
pickImageUrl({ createdAt: new Date() }),
);
expect(defaultImage.urls).toContain(res.data.checkLinkPreview.image);
expect(res.data.checkLinkPreview.id).toBeFalsy();
});

Expand Down Expand Up @@ -5611,11 +5728,27 @@ describe('mutation createFreeformPost', () => {
it('should list scheduled posts', async () => {
loggedUser = '1';
const scheduledAt = new Date(Date.now() + 60_000).toISOString();
const shareScheduledAt = new Date(Date.now() + 120_000).toISOString();
const createRes = await client.mutate(MUTATION, {
variables: { ...params, scheduledAt },
});

expect(createRes.errors).toBeFalsy();
await con.getRepository(SharePost).save({
id: 'sched-share',
shortId: 'sched-share',
authorId: '1',
sourceId: 'a',
sharedPostId: 'p1',
title: 'Scheduled share',
type: PostType.Share,
visible: false,
visibleAt: null,
flags: {
visible: false,
scheduledAt: shareScheduledAt,
},
});

const res = await client.query(/* GraphQL */ `
query ScheduledPosts {
Expand All @@ -5624,6 +5757,7 @@ describe('mutation createFreeformPost', () => {
node {
id
title
type
flags {
scheduledAt
}
Expand All @@ -5639,11 +5773,22 @@ describe('mutation createFreeformPost', () => {
node: {
id: createRes.data.createFreeformPost.id,
title: params.title,
type: PostType.Freeform,
flags: {
scheduledAt,
},
},
},
{
node: {
id: 'sched-share',
title: 'Scheduled share',
type: PostType.Share,
flags: {
scheduledAt: shareScheduledAt,
},
},
},
]);
});

Expand Down Expand Up @@ -5716,11 +5861,11 @@ describe('mutation createFreeformPost', () => {
);
});

it('should return an error if content exceeds 10000 characters', async () => {
it('should return an error if content exceeds 20000 characters', async () => {
loggedUser = '1';

const content = 'Hello World! Start your squad journey here'; // 42 chars
const sample = new Array(240).fill(content); // 42*240 = 10_080
const content = 'Hello World! Start your squad journey here';
const sample = new Array(480).fill(content);

return testMutationErrorCode(
client,
Expand Down Expand Up @@ -7167,11 +7312,11 @@ describe('mutation editPost', () => {
);
});

it('should return an error if content exceeds 10000 characters', async () => {
it('should return an error if content exceeds 20000 characters', async () => {
loggedUser = '1';

const content = 'Hello World! Start your squad journey here'; // 42 chars
const sample = new Array(240).fill(content); // 42*240 = 10_080
const content = 'Hello World! Start your squad journey here';
const sample = new Array(480).fill(content);

return testMutationErrorCode(
client,
Expand Down
64 changes: 64 additions & 0 deletions __tests__/workers/cdc/primary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8118,6 +8118,7 @@ describe('poll post', () => {
type: PostType.Poll,
authorId: pollAuthorId,
createdAt,
visible: true,
},
op: 'c',
table: 'post',
Expand All @@ -8134,6 +8135,69 @@ describe('poll post', () => {
expect(userAchievement!.unlockedAt).not.toBeNull();
});

it('should not unlock the poll achievement on scheduled poll creation', async () => {
const pollId = randomUUID();
const createdAt = new Date('2021-09-22T07:15:51.247Z').getTime() * 1000;

await expectSuccessfulBackground(
worker,
mockChangeMessage<PollPost>({
after: {
id: pollId,
type: PostType.Poll,
authorId: pollAuthorId,
createdAt,
visible: false,
},
op: 'c',
table: 'post',
}),
);

const userAchievement = await con.getRepository(UserAchievement).findOneBy({
achievementId: pollAchievementId,
userId: pollAuthorId,
});

expect(userAchievement).toBeNull();
});

it('should unlock the poll achievement when scheduled poll becomes visible', async () => {
const pollId = randomUUID();
const createdAt = new Date('2021-09-22T07:15:51.247Z').getTime() * 1000;

await expectSuccessfulBackground(
worker,
mockChangeMessage<PollPost>({
before: {
id: pollId,
type: PostType.Poll,
authorId: pollAuthorId,
createdAt,
visible: false,
},
after: {
id: pollId,
type: PostType.Poll,
authorId: pollAuthorId,
createdAt,
visible: true,
},
op: 'u',
table: 'post',
}),
);

const userAchievement = await con.getRepository(UserAchievement).findOneBy({
achievementId: pollAchievementId,
userId: pollAuthorId,
});

expect(userAchievement).not.toBeNull();
expect(userAchievement!.progress).toEqual(1);
expect(userAchievement!.unlockedAt).not.toBeNull();
});

it('should cancel entity reminder workflow when poll is deleted', async () => {
const pollId = randomUUID();
const createdAt = new Date('2021-09-22T07:15:51.247Z').getTime() * 1000; // Convert to debezium microseconds
Expand Down
Loading
Loading