feat(posts): support scheduled publishing#3974
Merged
Merged
Conversation
idoshamun
force-pushed
the
codex/scheduled-posts
branch
from
93da7fb to
ce9ded4
Compare
|
🍹 The Update (preview) for dailydotdev/api/prod (at d33b947) was successful. Resource Changes Name Type Operation
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-materialize-monthly-best-post-archives-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-squad-posts-analytics-refresh-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-channel-highlights-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-achievement-rarity-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-worker-job-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-expire-super-agent-trial-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-clickhouse-migration-6c5c6ea8 kubernetes:batch/v1:Job delete
~ vpc-native-user-posts-analytics-refresh-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-subscription-anniversary-achievements-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-lifecycle-state-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-materialized-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-db-migration-6c5c6ea8 kubernetes:batch/v1:Job delete
+ vpc-native-api-clickhouse-migration-0fcce16f kubernetes:batch/v1:Job create
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-expired-better-auth-sessions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-rotate-daily-quests-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
... and 15 other changes |
idoshamun
commented
Jul 2, 2026
| visible: true, | ||
| visibleAt: now, | ||
| createdAt: now, | ||
| score: getPostScore(now), |
Member
Author
There was a problem hiding this comment.
Why do we need score? Is it something we have anywhere?
idoshamun
commented
Jul 2, 2026
idoshamun
commented
Jul 2, 2026
| export const getPostScheduledAt = ({ | ||
| flags, | ||
| }: PostScheduleFlagsInput): Date | null => { | ||
| const parsedFlags = |
Member
Author
There was a problem hiding this comment.
Why flags can be a string?
idoshamun
commented
Jul 2, 2026
Comment on lines
+108
to
+109
| deleted: false, | ||
| banned: false, |
Member
Author
There was a problem hiding this comment.
we shouldnt touch these fields. ignore them
idoshamun
commented
Jul 2, 2026
| @Index('IDX_post_flags_banned', { synchronize: false }) | ||
| @Index('IDX_post_flags_deleted', { synchronize: false }) | ||
| @Index('IDX_post_flags_vordr', { synchronize: false }) | ||
| @Index('IDX_post_flags_scheduledAt', { synchronize: false }) |
Member
Author
There was a problem hiding this comment.
Why do we need this index?
idoshamun
commented
Jul 2, 2026
| includeInvisiblePosts?: boolean; | ||
| }; | ||
|
|
||
| const withInvisiblePosts = ( |
Member
Author
There was a problem hiding this comment.
I don't like this prototype hacking. Suggest alternatives
idoshamun
commented
Jul 2, 2026
idoshamun
left a comment
idoshamun
left a comment
Member
Author
There was a problem hiding this comment.
I see a lot Object.prototype tricks which I dont really like and we have no where else in the codebase.
Have we added the new workflow to our temporal service here so it won't be left out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flags.scheduledAtand hidden visibility until publish time.createdAt/score on publish, and cancel stale workflows on edit/delete/publish.Validation
pnpm run buildpnpm run lintNODE_ENV=test npx jest __tests__/posts.ts --testEnvironment=node --runInBandNODE_ENV=test npx jest __tests__/temporal/notifications/activities.ts __tests__/temporal/notifications/utils.ts --testEnvironment=node --runInBandNODE_ENV=test npx jest __tests__/temporal/notifications/workflows.ts --testEnvironment=node --runInBand