kernel_install_dep.sh: Use VERSION_ID to differentate between major versions#72
Merged
Merged
Conversation
…ersions Now that we're using maching basic images, there is a discrepancy for rocky 8.6 images: ROCKY_SUPPORT_PRODUCT='Rocky Linux'. Since ROCKY_SUPPORT_PRODUCT is not the same for all versions, use VERSION_ID instead. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
There was a problem hiding this comment.
Pull request overview
This PR updates kernel_install_dep.sh to detect Rocky major versions using /etc/os-release’s VERSION_ID (major component) instead of ROCKY_SUPPORT_PRODUCT, avoiding mismatches across Rocky minor versions (e.g., 8.6).
Changes:
- Switch distro/major-version branching from
ROCKY_SUPPORT_PRODUCTto${VERSION_ID%%.*}. - Map detected major versions (8/9/10) to the corresponding kselftest dependency install functions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT as it breaks kt vm lts8.6 and kt content-release lts8.6.
If people use the new images introduced here #70
Feel free to merge this even if I am not here.
Description
Now that we're using maching basic images, there is a discrepancy for rocky 8.6 images:
ROCKY_SUPPORT_PRODUCT='Rocky Linux'.
Since ROCKY_SUPPORT_PRODUCT is not the same for all versions, use VERSION_ID instead.
Tested here
#71