fix: make datetimes tz-aware to avoid naive/aware mix errors#276
Merged
Conversation
Replace naive datetime.utcnow() with datetime.now(timezone.utc) in FetchResult.time and the NftOffer.start_time fallback, add tz=utc to unisat's fromtimestamp (which also fixes a local-offset shift), and make parse_dt always return a tz-aware datetime (assume UTC for strings without a timezone) so it is consistent with its numeric paths. This prevents "can't subtract offset-naive and offset-aware datetimes" downstream when these values are compared/subtracted. Updates 3 tests that asserted the old naive behaviour and documents the two spots (DebankProtocolCache, v1 RateLimit) that stay naive on purpose. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
galvanizze
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace naive datetime.utcnow() with datetime.now(timezone.utc) in FetchResult.time and the NftOffer.start_time fallback, add tz=utc to unisat's fromtimestamp (which also fixes a local-offset shift), and make parse_dt always return a tz-aware datetime (assume UTC for strings without a timezone) so it is consistent with its numeric paths.
This prevents "can't subtract offset-naive and offset-aware datetimes" downstream when these values are compared/subtracted. Updates 3 tests that asserted the old naive behaviour and documents the two spots (DebankProtocolCache, v1 RateLimit) that stay naive on purpose.