Add LZSS support for PackType=1 (original code only handled BMR)#196
Open
diandianxz wants to merge 3 commits into
Open
Add LZSS support for PackType=1 (original code only handled BMR)#196diandianxz wants to merge 3 commits into
diandianxz wants to merge 3 commits into
Conversation
Add a decompression method that decides whether to use BMR or LZSS based on the value of flag & 3
Add LZSS decompression support for PackType=1 Original code hardcoded only BMR (PackType=2), ignoring the control flag. Now both PackType=1 (LZSS) and PackType=2 (BMR) are supported. Tested locally with existing BMR files (no regression) and new LZSS files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already verified locally
Verified game: エンジョイサマー マキシマム
Verified files: cg00.arc, cg000Bモ3甲.plt, etc.
Hex analysis matches game reverse engineering results.
The original code only looks at the first 4 bytes and checks for "BMR".
But the control flag (flags & 3) already tells you what compression it is.
flags & 3 == 2 -> BMR (unchanged)
flags & 3 == 1 -> LZSS (added)
I tested it locally and CI also passes now (see attached).
This is not a breaking change. Old BMR work exactly the same as before.
LZSS just start working.
Indentation might not be perfect but it works.