[CDF-28175] Fix location filter asset subtree key compatibility

[ronpal]

Description

We introduced an error with Pydantic classes for location filters, mixing assetSubtreeIds (correct) and assetSubtreeExternalIds (wrong). This change keeps compatibility by accepting both in location YAML and normalizing deploy payloads to API-compatible subtree IDs.

Bump

• Patch
• Skip

Changelog

Fixed

• Fixed location filter asset subtree key handling so build and deploy accept compatible syntax.

[ronpal]

/gemini review

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[gemini-code-assist]

Code Review

This pull request adds support for the assetSubtreeIds alias alongside assetSubtreeExternalIds in location filter resources, updating both the loader logic and Pydantic models, and adding corresponding unit tests. The review feedback highlights potential runtime errors (such as AttributeError and TypeError) if these fields or subfilters are explicitly set to null in the YAML configuration, recommending defensive checks and safe defaults (or []) during dictionary operations and list unpacking.

[github-actions]

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements	Covered	Coverage	Threshold	Status
43836	37728	86%	80%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
cognite_toolkit/_cdf_tk/resource_ios/_resource_ios/location.py	85%	🟢
cognite_toolkit/_cdf_tk/yaml_classes/location.py	100%	🟢
TOTAL	92%	🟢

updated for commit: e6a913e by action🐍

[codecov]

Codecov Report

❌ Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (080ba9e) to head (3111e14).

Files with missing lines	Patch %	Lines
cognite_toolkit/_cdf_tk/commands/repo.py	92.68%	3 Missing ⚠️
cognite_toolkit/_cdf_tk/utils/fileio/_writers.py	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   86.04%   86.06%   +0.01%     
==========================================
  Files         475      475              
  Lines       43828    43881      +53     
==========================================
+ Hits        37712    37765      +53     
  Misses       6116     6116              

Files with missing lines	Coverage Δ
...kit/_cdf_tk/resource_ios/_resource_ios/location.py	84.57% <100.00%> (+0.68%)	⬆️
cognite_toolkit/_cdf_tk/utils/fileio/_base.py	95.83% <100.00%> (+0.37%)	⬆️
cognite_toolkit/_cdf_tk/yaml_classes/location.py	100.00% <100.00%> (ø)
cognite_toolkit/_cdf_tk/utils/fileio/_writers.py	82.57% <71.42%> (-0.58%)	⬇️
cognite_toolkit/_cdf_tk/commands/repo.py	81.81% <92.68%> (+14.57%)	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ronpal]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for appending missing .gitignore entries during repository initialization and adds alias support for assetSubtreeIds and assetSubtreeExternalIds in location filters. Feedback highlights a missing type hint on a class attribute in repo.py, and several potential runtime errors (such as AttributeError and TypeError) in location.py if filters or subfilters are None or not dictionaries.

[Magssch]

LGTM!