Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to Sphinx 9.1.0 is incompatible with the project's current Python version requirements. This project supports Python >=3.10 (as specified in pyproject.toml), but Sphinx 9.1.0 requires Python 3.12 or higher. According to the release notes, Sphinx 8.2.0 dropped support for Python 3.10 and Sphinx 9.1.0 dropped support for Python 3.11. This change will cause documentation builds to fail in environments running Python 3.10 or 3.11. If you wish to upgrade while maintaining Python 3.10 support, consider using Sphinx 8.1.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review comment needs to be addressed.