v1.1.1: decode entities in status/setup titles; add 'tapdeck play'#9
Merged
Conversation
_browseItems decoded the res/resMD but not dc:title, so titles with apostrophes or ampersands showed raw XML entities in status/setup output. Playback was unaffected. Decode the title too.
…cal card Runs the text through the card path (processSonosCommand), so a Spotify URI can be tested against the configured spotify_account_sn without programming a tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to v1.1.0.
_browseItemsdecoded the<res>/<r:resMD>but notdc:title, so track titles with apostrophes/ampersands (e.g.Don't Start Now,Rock & Roll) showed raw XML entities instatus/setupoutput. Playback was never affected — display only. Now decodes the title too (with a regression test).tapdeck play <tag text>runs a single tag through the card path without a physical tag — e.g.tapdeck play spotify:track:<id>to test a Spotify URI against the configuredspotify_account_sn.Gate green: fmt, lint, check, 41 tests.