BaseCatcher abstraction added by Reversean · Pull Request #161 · codex-team/hawk.javascript

Reversean · 2026-02-12T18:34:58Z

Closes #151

Env-agnostic logic from Catcher in @hawk.so/javascript moved in new abstract BaseCatcher in @hawk.so/core so general logic (breadcrumbs management, user management, context management, message pre-processing and sending, and other utilities) may be reused in other platform-specific implementations.

Browser-specific logic (UI-framework integrations, window event listeners, ConsoleCatcher) remain in original Catcher in @hawk.so/javascript.

neSpecc

The PR contains changes for other PRs

Env-agnostic logic from Catcher in @hawk.so/javascript moved in new abstract BaseCatcher so general logic (breadcrumbs management, user management, context management, message pre-processing and sending, and other utilities) may be reused in other platform-specific implementations. Browser-specific logic (UI-framework integrations, window event listeners, ConsoleCatcher) remain in original Catcher in @hawk.so/javascript.

Reversean · 2026-05-06T18:40:30Z

The PR contains changes for other PRs

Should be fixed yet.

Copilot

Pull request overview

This PR extracts environment-agnostic catcher logic from @hawk.so/javascript into a new reusable BaseCatcher in @hawk.so/core, keeping browser-specific behavior in the JavaScript catcher.

Changes:

Introduced BaseCatcher in @hawk.so/core to host shared event pipeline logic (context/user/breadcrumbs/processors/beforeSend/transport dispatch).
Refactored @hawk.so/javascript Catcher to extend BaseCatcher and keep browser-only concerns (Socket transport wiring, window handlers, console tracking, breadcrumbs store, performance issues).
Adjusted addon imports and bumped @hawk.so/javascript patch version.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/javascript/src/catcher.ts	Refactors JS Catcher to extend the new core `BaseCatcher` and wires browser-specific transport/processors/handlers.
packages/javascript/src/addons/console-output-addon-message-processor.ts	Fixes relative import path for `ConsoleCatcher`.
packages/javascript/src/addons/browser-breadcrumbs-message-processor.ts	Fixes relative import paths for breadcrumbs types/store.
packages/javascript/package.json	Bumps package version to 3.3.2.
packages/core/src/index.ts	Exports `BaseCatcher` and `BeforeSendHook` from core public API.
packages/core/src/catcher.ts	Adds the new `BaseCatcher` abstraction containing shared catcher logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+ * Each {@link formatAndSend} call initiates **sending pipeline** which consist of following steps:
+ * - base payload is built,
+ * - sequentially apply message processors to payload
+ * - apply optional {@link BeforeSendHook},
+ * - dispatch message via {@link Transport}.


+  /**
+   * Process and sends error message.
+   *
+   * Returns early without sending if:
+   * - error was already processed,
+   * - a message processor drops it,
+   * - {@link beforeSend} hook rejects it.
+   *
+   * @param error - error to send
+   * @param integrationAddons - addons passed by integration (e.g. Vue, Nuxt)
+   * @param context - any additional data passed by user
+   */
+  protected async formatAndSend(
+    error: Error | string,
+    integrationAddons?: Record<string, unknown>,
+    context?: EventContext
+  ): Promise<void> {
+    try {
+      if (isErrorProcessed(error)) {
+        return;
+      }
+
+      markErrorAsProcessed(error);
+
+      let processingPayload = await this.buildBasePayload(error, context);
+
+      for (const processor of this.messageProcessors) {
+        const result = processor.apply(processingPayload, error);
+
+        if (result === null) {
+          // Event was rejected by user using the beforeSend method
+          return;
+        }
+
+        processingPayload = result;
+      }
+
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      const payload = processingPayload as any as CatcherMessagePayload<T>;
+
+      if (integrationAddons) {
+        payload.addons = {
+          ...(payload.addons ?? {}),
+          ...Sanitizer.sanitize(integrationAddons),
+        };
+      }
+
+      const filtered = this.applyBeforeSendHook(payload);
+
+      if (filtered === null) {
+        return;
+      }
+
+      this.sendMessage({
+        token: this.token,
+        catcherType: this.getCatcherType(),
+        payload: filtered,
+      } as CatcherMessage<T>);
+    } catch (e) {
+      log('Unable to send error. Seems like it is Hawk internal bug. Please, report it here: https://github.com/codex-team/hawk.javascript/issues/new', 'warn', e);
+    }
+  }


neSpecc · 2026-05-13T11:50:08Z

   */
-  public test(): void {
-    const fakeEvent = new Error('Hawk JavaScript Catcher test message.');
+  private static decodeIntegrationId(token: EncodedIntegrationToken): string {


probably also can be reused across browser/node catchers, so could be moved to base catcher or utility.

neSpecc · 2026-05-13T11:51:22Z

+    // Promise rejection reason is recommended to be an Error, but it can be a string:
+    // - Promise.reject(new Error('Reason message')) ——— recommended
+    // - Promise.reject('Reason message')


use block-style comments please as we do in our code style

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Reversean changed the title ~~refactor(core): BaseCatcher abstraction added~~ BaseCatcher abstraction added Feb 12, 2026

Reversean marked this pull request as draft February 12, 2026 18:36

Reversean force-pushed the refactor/catcher-logger branch from 6d66554 to 0ca5710 Compare February 12, 2026 18:49

Reversean force-pushed the refactor/base-catcher branch from 79ab0f0 to dd4f541 Compare February 12, 2026 18:49

Reversean force-pushed the refactor/catcher-logger branch from 0ca5710 to 4ad2b5f Compare February 12, 2026 19:45

Reversean force-pushed the refactor/base-catcher branch from dd4f541 to ee65ab6 Compare February 13, 2026 13:21

Reversean force-pushed the refactor/catcher-logger branch 7 times, most recently from f99d5fe to 173d40e Compare February 22, 2026 14:51

Reversean force-pushed the refactor/catcher-logger branch 2 times, most recently from 1cb3077 to 70d214e Compare February 25, 2026 17:35

Reversean force-pushed the refactor/catcher-logger branch 5 times, most recently from cc8919a to f460ea3 Compare March 7, 2026 19:29

Base automatically changed from refactor/catcher-logger to master March 8, 2026 08:03

Reversean force-pushed the refactor/base-catcher branch from ee65ab6 to 0f9ed18 Compare April 8, 2026 09:11

Reversean changed the base branch from master to refactor/message-processor April 8, 2026 09:57

Reversean marked this pull request as ready for review April 8, 2026 09:58

Reversean force-pushed the refactor/base-catcher branch from 0f9ed18 to fcb3798 Compare April 22, 2026 14:31

neSpecc requested changes Apr 22, 2026

View reviewed changes

Reversean force-pushed the refactor/base-catcher branch 3 times, most recently from 5b9716d to 4a6adc0 Compare April 29, 2026 07:11

Reversean changed the base branch from refactor/message-processor to refactor/breadcrumb-store April 29, 2026 07:14

Reversean force-pushed the refactor/breadcrumb-store branch from a02cf33 to b8c9b5c Compare April 29, 2026 07:35

Reversean force-pushed the refactor/base-catcher branch from 4a6adc0 to 16ca176 Compare April 29, 2026 07:40

Reversean force-pushed the refactor/breadcrumb-store branch from b8c9b5c to c049bd4 Compare April 29, 2026 07:43

Reversean force-pushed the refactor/base-catcher branch from 16ca176 to 465508d Compare April 29, 2026 07:43

Reversean requested a review from neSpecc April 29, 2026 07:45

Reversean force-pushed the refactor/breadcrumb-store branch 3 times, most recently from 9248931 to 9e5d66a Compare May 6, 2026 18:27

Base automatically changed from refactor/breadcrumb-store to master May 6, 2026 18:28

Reversean force-pushed the refactor/base-catcher branch from 465508d to 53ed83c Compare May 6, 2026 18:40

neSpecc requested a review from Copilot May 13, 2026 11:45

Copilot started reviewing on behalf of neSpecc May 13, 2026 11:46 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

neSpecc reviewed May 13, 2026

View reviewed changes

Reversean and others added 3 commits May 13, 2026 17:03

fix: pull request findings

3a11b71

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: pull request findings

c532d79

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: pull request findings

76c36bd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BaseCatcher abstraction added#161

BaseCatcher abstraction added#161
Reversean wants to merge 4 commits into
masterfrom
refactor/base-catcher

Reversean commented Feb 12, 2026 •

edited

Loading

Uh oh!

neSpecc left a comment

Uh oh!

Reversean commented May 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neSpecc May 13, 2026

Uh oh!

neSpecc May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Reversean commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neSpecc left a comment

Choose a reason for hiding this comment

Uh oh!

Reversean commented May 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neSpecc May 13, 2026

Choose a reason for hiding this comment

Uh oh!

neSpecc May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Reversean commented Feb 12, 2026 •

edited

Loading