Updated previousLogin method to use limit() and first() model methods instead.

sammyskills · sammyskills · commit d151ee725b36 · 2022-07-24T05:50:16.000+01:00
diff --git a/src/Models/LoginModel.php b/src/Models/LoginModel.php
@@ -74,11 +74,10 @@ public function recordLoginAttempt(
      */
     public function previousLogin(User $user): ?Login
     {
-        $previous = $this->where('success', 1)
+        return $this->where('success', 1)
             ->where('user_id', $user->id)
             ->orderBy('id', 'desc')
-            ->findAll(1, 1);
-        return ($previous) ? $previous[0] : NULL;
+            ->limit(1, 1)->first();
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -74,11 +74,10 @@ public function recordLoginAttempt(`
`74`	`74`	`*/`
`75`	`75`	`public function previousLogin(User $user): ?Login`
`76`	`76`	`{`
`77`		`- $previous = $this->where('success', 1)`
	`77`	`+ return $this->where('success', 1)`
`78`	`78`	`->where('user_id', $user->id)`
`79`	`79`	`->orderBy('id', 'desc')`
`80`		`- ->findAll(1, 1);`
`81`		`- return ($previous) ? $previous[0] : NULL;`
	`80`	`+ ->limit(1, 1)->first();`
`82`	`81`	`}`
`83`	`82`
`84`	`83`	`/**`