Updated previousLogin method to use the model's method and added test

Author: sammyskills

src/Models/LoginModel.php

@@ -74,10 +74,11 @@ public function recordLoginAttempt(
      */
     public function previousLogin(User $user): ?Login
     {
-        return $this->where('success', 1)
+        $previous = $this->where('success', 1)
             ->where('user_id', $user->id)
-            ->orderBy('id', 'desc')->get()
-            ->getRow(1, Login::class);
+            ->orderBy('id', 'desc')
+            ->findAll(1, 1);
+        return ($previous) ? $previous[0] : NULL;
     }
 
     /**

tests/Unit/UserTest.php

@@ -114,6 +114,41 @@ public function testLastLogin(): void
         $this->assertInstanceOf(Time::class, $last->date);
     }
 
+    public function testPreviousLogin(): void
+    {
+        fake(
+            UserIdentityModel::class,
+            ['user_id' => $this->user->id, 'type' => Session::ID_TYPE_EMAIL_PASSWORD, 'secret' => 'foo@example.com']
+        );
+
+        // No logins found.
+        $this->assertNull($this->user->previousLogin());
+
+        fake(
+            LoginModel::class,
+            ['id_type' => 'email', 'identifier' => $this->user->email, 'user_id' => $this->user->id]
+        );
+        $login2 = fake(
+            LoginModel::class,
+            ['id_type' => 'email', 'identifier' => $this->user->email, 'user_id' => $this->user->id]
+        );
+        fake(
+            LoginModel::class,
+            [
+                'id_type'    => 'email',
+                'identifier' => $this->user->email,
+                'user_id'    => $this->user->id,
+                'success'    => false,
+            ]
+        );
+
+        $previous = $this->user->previousLogin();
+
+        $this->assertInstanceOf(Login::class, $previous); // @phpstan-ignore-line
+        $this->assertSame($login2->id, $previous->id);
+        $this->assertInstanceOf(Time::class, $previous->date);
+    }
+
     /**
      * @see https://github.com/codeigniter4/shield/issues/103
      */