fix: use default retriever router#998
Open
mahoushoujyo-eee wants to merge 1 commit intocloudwego:mainfrom
Open
fix: use default retriever router#998mahoushoujyo-eee wants to merge 1 commit intocloudwego:mainfrom
mahoushoujyo-eee wants to merge 1 commit intocloudwego:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a nil-pointer panic in the retriever router by ensuring the resolved (default) router function is stored on the constructed routerRetriever when Config.Router is not provided.
Changes:
- Store the resolved
router(default or user-provided) inrouterRetrieverinstead ofconfig.Router. - Add a regression test verifying the default routing behavior calls all registered retrievers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flow/retriever/router/router.go | Fixes the nil router assignment by storing the resolved default router function. |
| flow/retriever/router/router_test.go | Adds a regression test to ensure the default router queries all configured retrievers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #954
Summary
Config.Routeris nilTests
go test ./flow/retriever/routergo test ./flow/retriever/...golangci-lint run ./flow/retriever/router --timeout 5mNote:
go test ./...currently has unrelated Windows-local failures in ADK filesystem/plantask/reduction tests and a CRLF/path assertion.golangci-lint run ./... --timeout 5mreports unrelated existinggciissues in files not touched by this PR.