Merge pull request #37 from cloudgraphdev/fix/CG-1084

tyler-dunkel · web-flow · commit a73c6b1bb9c0 · 2022-04-13T11:06:03.000-05:00
fix: iamInstanceProfile never returning when there's a permission's e…
diff --git a/src/services/iamInstanceProfile/data.ts b/src/services/iamInstanceProfile/data.ts
@@ -56,15 +56,19 @@ export const listInstancesProfiles = async (
               })
             }
 
-            const { InstanceProfiles = [], IsTruncated, Marker } = data
+            if (!isEmpty(data)) {
+              const { InstanceProfiles = [], IsTruncated, Marker } = data
 
-            instanceProfileList.push(...InstanceProfiles)
+              instanceProfileList.push(...InstanceProfiles)
 
-            if (IsTruncated) {
-              listAllInstanceProfiles(Marker)
+              if (IsTruncated) {
+                listAllInstanceProfiles(Marker)
+              }
+
+              resolve(instanceProfileList)
             }
 
-            resolve(instanceProfileList)
+            resolve([])
           }
         )
       } catch (error) {

Original file line number	Diff line number	Diff line change
`@@ -56,15 +56,19 @@ export const listInstancesProfiles = async (`
`56`	`56`	`})`
`57`	`57`	`}`
`58`	`58`
`59`		`- const { InstanceProfiles = [], IsTruncated, Marker } = data`
	`59`	`+ if (!isEmpty(data)) {`
	`60`	`+ const { InstanceProfiles = [], IsTruncated, Marker } = data`
`60`	`61`
`61`		`- instanceProfileList.push(...InstanceProfiles)`
	`62`	`+ instanceProfileList.push(...InstanceProfiles)`
`62`	`63`
`63`		`- if (IsTruncated) {`
`64`		`- listAllInstanceProfiles(Marker)`
	`64`	`+ if (IsTruncated) {`
	`65`	`+ listAllInstanceProfiles(Marker)`
	`66`	`+ }`
	`67`	`+`
	`68`	`+ resolve(instanceProfileList)`
`65`	`69`	`}`
`66`	`70`
`67`		`- resolve(instanceProfileList)`
	`71`	`+ resolve([])`
`68`	`72`	`}`
`69`	`73`	`)`
`70`	`74`	`} catch (error) {`