fix: iamInstanceProfile never returning when there's a permission's error

m-pizarro · m-pizarro · commit 63e6d4a3b862 · 2022-04-13T13:01:58.000-03:00
diff --git a/src/services/iamInstanceProfile/data.ts b/src/services/iamInstanceProfile/data.ts
@@ -54,15 +54,19 @@ export const listInstancesProfiles = async (
               })
             }
 
-            const { InstanceProfiles = [], IsTruncated, Marker } = data
+            if (!isEmpty(data)) {
+              const { InstanceProfiles = [], IsTruncated, Marker } = data
 
-            instanceProfileList.push(...InstanceProfiles)
+              instanceProfileList.push(...InstanceProfiles)
 
-            if (IsTruncated) {
-              listAllInstanceProfiles(Marker)
+              if (IsTruncated) {
+                listAllInstanceProfiles(Marker)
+              }
+
+              resolve(instanceProfileList)
             }
 
-            resolve(instanceProfileList)
+            resolve([])
           }
         )
       } catch (error) {

Original file line number	Diff line number	Diff line change
`@@ -54,15 +54,19 @@ export const listInstancesProfiles = async (`
`54`	`54`	`})`
`55`	`55`	`}`
`56`	`56`
`57`		`- const { InstanceProfiles = [], IsTruncated, Marker } = data`
	`57`	`+ if (!isEmpty(data)) {`
	`58`	`+ const { InstanceProfiles = [], IsTruncated, Marker } = data`
`58`	`59`
`59`		`- instanceProfileList.push(...InstanceProfiles)`
	`60`	`+ instanceProfileList.push(...InstanceProfiles)`
`60`	`61`
`61`		`- if (IsTruncated) {`
`62`		`- listAllInstanceProfiles(Marker)`
	`62`	`+ if (IsTruncated) {`
	`63`	`+ listAllInstanceProfiles(Marker)`
	`64`	`+ }`
	`65`	`+`
	`66`	`+ resolve(instanceProfileList)`
`63`	`67`	`}`
`64`	`68`
`65`		`- resolve(instanceProfileList)`
	`69`	`+ resolve([])`
`66`	`70`	`}`
`67`	`71`	`)`
`68`	`72`	`} catch (error) {`