fix: preserve Content-Length on blob and manifest GET/HEAD#136
Open
m-ferrero wants to merge 1 commit into
Open
fix: preserve Content-Length on blob and manifest GET/HEAD#136m-ferrero wants to merge 1 commit into
m-ferrero wants to merge 1 commit into
Conversation
Set Content-Encoding: identity so the runtime does not switch these responses to chunked transfer-encoding (which drops Content-Length); the distribution spec requires Content-Length on blob and manifest GET/HEAD. Adds regression tests for the blob/manifest GET and HEAD headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a client sends
Accept-Encoding: gzip, the runtime gzip-encodes blob and manifest GET responses and switches them to chunked transfer-encoding, dropping theContent-Lengththe distribution spec requires. It only manifests at the real wire layer (Gonet/http-style clients, the OCI conformance suite); a plain in-process fetch does not trigger it.Solution
Set
Content-Encoding: identityon the blob and manifest GET responses so the body is served verbatim and itsContent-Lengthis preserved. The matching HEAD responses set it too, so a HEAD's headers mirror its GET.Tests
Adds assertions that
Content-Length(andContent-Encoding: identity) is present and correct on blob and manifest GET and HEAD.Part of #134.