Reconcile Think follow-ups and extend runTurn stream input#1799
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: a3633e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat:turn:*metadata coverage for wait/continuation/RPC/sequential turns, skipped empty input, and the current absence ofchannelon the turn observability payload.Think.runTurn({ mode: "stream" })to accept array and function inputs by wideningchat()to resolveTurnInputMessagesinside the queued turn.submit+ function input rejected because durable submission cannot serialize a function input yet.Why
The design docs had drifted behind implementation state, and
runTurnstream mode still had an artificial input-shape gap after_admitTurnshipped. This PR lines the docs up with the code, adds executable coverage for the turn metadata contract, and makes stream mode match the practicalwaitmode input surface for arrays/functions.Implementation notes
""/[]) still creates a request id, callsonStart, then callsonDonewithout running inference or persisting messages._admitTurnagainst the in-queue transcript. A function returning[]preserves existing programmatic behavior: it runs against existing history when present rather than being pre-skipped.agentspinspartysocketat1.2.0; it should land after the upstreamshouldReconnectOnCloserelease from Add partysocket terminal close reconnect predicate partykit#409.Test plan
pnpm exec vitest --run -c src/tests/vitest.config.ts src/tests/run-turn.test.tsfrompackages/think: passed, 26 tests.pnpm run check: passed, including Sherif, export checks, format check, oxlint, and typecheck across 113 projects.Made with Cursor