-
Notifications
You must be signed in to change notification settings - Fork 104
Raise Warning if the Capacity Array is Not Set But mapc2p is #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mandli
merged 9 commits into
clawpack:master
from
NDM14:feature/614/raise-warning-capacity
Feb 2, 2026
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
051c32a
- added method is_mapped_state_valid to state class to check whether …
NDM14 efde1bc
- changed the String of the ValueError for the capacity array
NDM14 0a576b4
- removed two unnecassary checks from method is_mapped_state_valid
NDM14 66f1661
- removed is_mapped_state_valid method to comply with the present pat…
NDM14 1b07b2f
updated error message to tell the user what he needs to do
NDM14 d348516
- Added Testclass and test to check for updated is_valid
NDM14 4f1e44a
moved test for state to tests directory
NDM14 41f2e03
added new check if there is a mapping to distinguish right cases
NDM14 2f526ee
Use exactly the same identity_map in State as in Geometry.
ketch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.