chore: bump @ckb-ccc/core to 1.14.0 to fix ws vulnerability#436
Open
humble-little-bear wants to merge 4 commits into
Open
chore: bump @ckb-ccc/core to 1.14.0 to fix ws vulnerability#436humble-little-bear wants to merge 4 commits into
humble-little-bear wants to merge 4 commits into
Conversation
Upgrades @ckb-ccc/core from 1.5.3 to 1.14.0 so the transitive ws dependency resolves to ^8.21.0, which patches the reported memory exhaustion DoS advisory.
ccc >= 1.14.0 calls getKnownScript(NervosDao) during completeFeeBy for every input. Devnet has no NervosDao deployment, so supplying the testnet definition lets isNervosDao() return false without throwing. Also add the missing changeset for the @ckb-ccc/core bump. Co-Authored-By: Claude <noreply@anthropic.com>
The github-script comment steps require pull-requests: write, which fork PRs do not receive with the pull_request trigger. Skip the optional comment steps on forks so the required changeset check can still pass/fail cleanly. Co-Authored-By: Claude <noreply@anthropic.com>
The previous fallback reused the testnet NervosDao definition. Devnet deploys its own DAO system cell, so map KnownScript.NervosDao to the devnet dao script derived from ckb list-hashes instead. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
@ckb-ccc/corefrom1.5.3to1.14.0so the transitivewsdependency resolves to^8.21.0, which patches the reported memory exhaustion DoS advisory.