fix: hide resize handles on size-locked panels#65
Merged
Conversation
Resize handles were being rendered in the DOM even when lockSize was true. They appeared visually on hover despite having no event handlers. Now conditionally renders handles only when resizeHandleProps is defined, properly hiding them for size-locked panels. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lockSize: trueWhy
The
lockSizefeature was not working correctly - resize handles appeared visually on hover even though size-locked panels couldn't actually be resized. This created a confusing user experience where the UI suggested an action that wasn't possible.Changes
PanelGridRenderer.tsxto conditionally render resize handlesresizeHandlePropsis definedlockSize: true,resizeHandlePropsisundefined, so no handles appearTest Plan
yarn typecheck)yarn test)Notes
This is a minimal fix that resolves the visual inconsistency. The logic in
usePanelGrid.tsthat setsresizeHandlePropstoundefinedfor locked panels was already correct - the issue was only in the rendering layer.