feat: add missing disputes filter params and dispute status enum value#174
Merged
Merged
Conversation
Add processing_channel_ids and segment_ids to DisputesQueryFilter to match GET /disputes swagger spec. Add missing arb_evidence_submitted value to DisputeStatus enum. Improve YARD docs on all filter fields with descriptions, constraints and comma-separated format notes.
|
david-ruiz-cko
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While investigating issue #127, a swagger compliance audit of
DisputesQueryFilterandDisputeStatusrevealed missing fields and an incomplete enum.Changes
lib/checkout_sdk/disputes/disputes_query_filter.rb— addprocessing_channel_idsandsegment_ids(present inGET /disputesswagger spec but missing from the class); improve YARD docs on all fields with descriptions, constraints and comma-separated format noteslib/checkout_sdk/disputes/dispute_status.rb— add missingARB_EVIDENCE_SUBMITTED = 'arb_evidence_submitted'enum value present in swaggerDispute.statusRoot cause
Swagger compliance gap: two query parameters (
processing_channel_ids,segment_ids) and one enum value (arb_evidence_submitted) were never added when the endpoint was implemented.Regarding the original report in #127: the SDK was generating the correct query string (
statuses=evidence_under_review). The 0-result behavior with combined filters is API-side data behavior, not an SDK bug.Testing
Closes #127