fix(core): use block height value in Exchange.Get error strings#4935
Open
cuiweixie wants to merge 1 commit intocelestiaorg:mainfrom
Open
fix(core): use block height value in Exchange.Get error strings#4935cuiweixie wants to merge 1 commit intocelestiaorg:mainfrom
cuiweixie wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
Pass block.Height to fmt.Errorf instead of &block.Height so %d formats the height correctly.
Wondertan
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exchange.Getused&block.Heightin severalfmt.Errorf/fmtcalls with%d, which formats the pointer value instead of the block height.Changes
block.Heightinstead of&block.Heightwhen formatting errors inGet.