refactor!: remove go-fraud dependency and related dead code#4934
Merged
refactor!: remove go-fraud dependency and related dead code#4934
Conversation
Remove the github.com/celestiaorg/go-fraud dependency and all fraud proof related code. Fraud proofs are no longer functional post-shwap and there are no plans to reintroduce them. Closes #4930 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wondertan
approved these changes
Apr 13, 2026
Contributor
Author
|
@vgonkivs can this PR be included in the next celestia-node release so that we can archive go-fraud. Concretely this PR doesn't need to be included in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4930
Remove the
github.com/celestiaorg/go-frauddependency from celestia-node. Fraud proofs are no longer functional post-shwap and there are no plans to reintroduce them. This reduces maintenance burden and allows archiving the go-fraud repository.Breaking change
The
fraudRPC namespace is removed. Node operators and clients that callfraud.Subscribeorfraud.Getwill receive errors after upgrading. TheFraudfield is also removed from the Go RPC client.These endpoints have been non-functional since the shwap migration — fraud proofs were never produced or validated post-shwap, so these methods returned no useful data. No action is needed unless you have tooling that explicitly calls the
fraudRPC namespace.What was removed
nodebuilder/fraud/— entire package (Module interface, API, ServiceBreaker, constructors, proof unmarshaler, mocks)share/eds/byzantine/bad_encoding.go— BadEncodingProof (BEFP) implementation and testsshare/eds/byzantine/pb/— protobuf definitions for BEFP serializationheader/headertest/fraud/— FraudMaker test helpernodebuilder/tests/fraud_test.go— fraud integration test (was already skipped)github.com/celestiaorg/go-fraud— removed from go.modWhat was preserved
share/eds/byzantine/byzantine.go—ErrByzantinetype (still used by cascade getter and full availability for error classification)share/eds/byzantine/share_proof.go—ShareWithProoftype andGetShareWithProof(still used byErrByzantine)Test plan
go build ./...passesgo test ./das/passesgo test ./share/eds/passes (including renamedTestByzantineError)go test ./api/...passes (includingTestModulesImplementFullAPI)scripts/check-go-mod-parity.shpassesgo-fraud,nodebuilder/fraud,BadEncodingProof, orServiceBreakerRelease notes
The following should be included in the release notes for the next release that contains this change:
🤖 Generated with Claude Code