Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
834 commits
Select commit Hold shift + click to select a range
3c72b64
Odata containment failure
rashmiangadi05 Sep 3, 2025
29f9d6d
ut fix
rishikunnath2747 Sep 3, 2025
cded0a4
UT coverage
rashmiangadi05 Sep 3, 2025
0306d2f
Merge branch 'develop' into containment-error-cds8
rashmiangadi05 Sep 3, 2025
abe4c99
Merge branch 'develop' into containment-error-cds8
rashmiangadi05 Sep 3, 2025
4e2f887
Merge branch 'containment-error-cds8' of https://github.com/cap-js/sd…
rashmiangadi05 Sep 3, 2025
d274274
Changes
rashmiangadi05 Sep 3, 2025
67a4921
Update index.test.js
rashmiangadi05 Sep 3, 2025
eccc4c6
Code changes
rashmiangadi05 Sep 3, 2025
6e63f20
Delete cap-js-sdm-1.6.1.tgz
rashmiangadi05 Sep 3, 2025
d523a6c
Create review.js
vibhutikumar07 Sep 4, 2025
1148709
Create gemini-ask.yml
vibhutikumar07 Sep 4, 2025
18c5b4f
Create gemini-pr-review.yml
vibhutikumar07 Sep 4, 2025
fdd6217
Update review.js
vibhutikumar07 Sep 4, 2025
6fa6274
Create gemini_issues_review.yml
vibhutikumar07 Sep 4, 2025
f7395c1
Update review.js
vibhutikumar07 Sep 4, 2025
13f30dc
Update gemini_issues_review.yml
vibhutikumar07 Sep 4, 2025
8d6d28f
Update review.js
vibhutikumar07 Sep 4, 2025
7ce3322
Update gemini-pr-review.yml
vibhutikumar07 Sep 4, 2025
a340e94
Update gemini_issues_review.yml
vibhutikumar07 Sep 4, 2025
d21e8b4
Update gemini-ask.yml
vibhutikumar07 Sep 4, 2025
f6c28b2
Integration test fix
rashmiangadi05 Sep 4, 2025
da4b305
Update api.js
rashmiangadi05 Sep 4, 2025
18e49d4
Update credentials.json
rashmiangadi05 Sep 4, 2025
ba35346
unnecessary files
rashmiangadi05 Sep 4, 2025
7429d06
Delete .DS_Store
rashmiangadi05 Sep 4, 2025
b17a528
Review comments
rashmiangadi05 Sep 4, 2025
8b33041
Update index.test.js
rashmiangadi05 Sep 4, 2025
1011f9d
CDS containment issue
rashmiangadi05 Sep 4, 2025
abd31cb
Update sdm.js
rashmiangadi05 Sep 4, 2025
be06a22
Update sdm.js
rashmiangadi05 Sep 4, 2025
99bc1c4
UT lint
rashmiangadi05 Sep 4, 2025
6f53e80
Update sdm.test.js
rashmiangadi05 Sep 4, 2025
88bc356
Update sdm.js
rashmiangadi05 Sep 4, 2025
0536210
Merge pull request #170 from cap-js/containment-error-cds8
rashmiangadi05 Sep 5, 2025
ff19273
ISsue167:Accessing undefined variable in error handler
rashmiangadi05 Sep 5, 2025
0cf9cb2
Merge pull request #174 from cap-js/Issue167
rashmiangadi05 Sep 5, 2025
7ae0db1
[Version]: Changed
akshatjain-official Sep 5, 2025
398cd2f
Package.json Version change
akshatjain-official Sep 5, 2025
cc4e4f0
Merge branch 'develop' into VersionChanged
yashmeet29 Sep 5, 2025
718ecf1
Expression Change
akshatjain-official Sep 5, 2025
ffc4e16
Merge pull request #177 from cap-js/VersionChanged
yashmeet29 Sep 9, 2025
0faafd9
Update dependabot.yml
vibhutikumar07 Sep 9, 2025
9e4e000
Link support
yashmeet29 Sep 16, 2025
332389d
Merge branch 'develop' into geminiai
vibhutikumar07 Sep 17, 2025
f1bea2d
Merge pull request #171 from cap-js/geminiai
vibhutikumar07 Sep 17, 2025
6e3fdab
Update README.md
yashmeet29 Sep 17, 2025
7d6f4d2
Fix for new link to visible on UI and UTs
yashmeet29 Sep 26, 2025
d6e31d7
UT fix
yashmeet29 Sep 26, 2025
338a9eb
Merge branch 'develop' into linkSupport
yashmeet29 Sep 26, 2025
f276bd3
lint fix
yashmeet29 Sep 26, 2025
da0139e
Merge branch 'linkSupport' of https://github.com/cap-js/sdm into link…
yashmeet29 Sep 26, 2025
0962b9b
sonar fix
yashmeet29 Sep 29, 2025
119d09a
UT fix
yashmeet29 Sep 29, 2025
1dde321
Review comments
yashmeet29 Oct 1, 2025
ea9613f
Merge pull request #183 from cap-js/linkSupport
yashmeet29 Oct 3, 2025
6424bfa
init
rishikunnath2747 Oct 8, 2025
545e698
editLinkSupport
Oct 13, 2025
bdc0dc4
removed unused import
Oct 13, 2025
97aa54a
message constants
Oct 14, 2025
bba2bda
NoSDM Role check added
Oct 14, 2025
9c71ca2
readme changes
Oct 16, 2025
10d5b66
updated message
Oct 16, 2025
16a50f7
Merge pull request #187 from cap-js/editLinkDev
deepikaSingh2711 Oct 16, 2025
491c14e
adding test cases
rishikunnath2747 Oct 25, 2025
db9ff54
Changes to support local tests when there are no attachments
rashmiangadi05 Oct 27, 2025
c53eea2
Update sdm.js
rashmiangadi05 Oct 27, 2025
2cf7dfb
[Fixed]: Tenant Update during Subscription
akshatjain-official Oct 28, 2025
8e77b05
Plugin Implementation Prevents Local Application Testing and Executio…
rashmiangadi05 Oct 28, 2025
613d28b
Update attachments-sdm.test.js
rashmiangadi05 Oct 28, 2025
8a5c119
[Added]: Unit test and Increased Coverage
akshatjain-official Oct 28, 2025
8da73e4
changelog update
rishikunnath2747 Oct 29, 2025
901e994
Formatting issues
rishikunnath2747 Oct 29, 2025
2ae203c
Merge pull request #195 from cap-js/changelog_v1.8.0
rishikunnath2747 Oct 29, 2025
4e0d230
Merge branch 'develop' into UpdateTenant
rishikunnath2747 Oct 30, 2025
484f3d4
Merge branch 'develop' into fixforlocaltest
rishikunnath2747 Oct 30, 2025
70b5e17
Merge pull request #194 from cap-js/UpdateTenant
akshatjain-official Oct 30, 2025
c50a070
Merge branch 'develop' into fixforlocaltest
yashmeet29 Oct 30, 2025
d458a78
Merge pull request #193 from cap-js/fixforlocaltest
rashmiangadi05 Oct 31, 2025
d96fb03
Improve error handling and update AI model version
vibhutikumar07 Nov 3, 2025
bbf55ad
Update Gemini PR Review workflow to trigger on comments
vibhutikumar07 Nov 3, 2025
dca8b14
Adding assert.format test case
rishikunnath2747 Nov 3, 2025
1a81928
Merge branch 'develop' into createLinkTests
rishikunnath2747 Nov 3, 2025
afeef4f
Merge pull request #186 from cap-js/createLinkTests
rishikunnath2747 Nov 4, 2025
5410610
edit link discard draft
Nov 6, 2025
f042e52
Merge branch 'develop' into editLinkDraft
Nov 6, 2025
6adc3bb
added unit tests
Nov 7, 2025
7e89c99
fix
Nov 7, 2025
e3c8515
fix
Nov 7, 2025
015804d
Update sdm.test.js
deepikaSingh2711 Nov 7, 2025
398fa75
clean up
Nov 7, 2025
51276a3
Merge branch 'editLinkDraft' of https://github.com/cap-js/sdm into ed…
Nov 7, 2025
92a253e
Revert "clean up"
Nov 7, 2025
e02de80
clean up
Nov 7, 2025
ab77a39
Role issuee: When SDM role not present proper error message
rashmiangadi05 Nov 10, 2025
0cd385e
Sonarr fix
rashmiangadi05 Nov 11, 2025
a53a886
Update index.js
rashmiangadi05 Nov 11, 2025
b7390c9
lint fix
rashmiangadi05 Nov 11, 2025
511090f
Merge branch 'develop' into roleerror
rashmiangadi05 Nov 11, 2025
74c02c2
Merge pull request #199 from cap-js/editLinkDraft
rishikunnath2747 Nov 12, 2025
fcee978
Changes
rashmiangadi05 Nov 13, 2025
5e83cd5
Update sdm.js
rashmiangadi05 Nov 13, 2025
4849f06
Update sdm.js
rashmiangadi05 Nov 13, 2025
2b15cdd
Update sdm.js
rashmiangadi05 Nov 13, 2025
303ef96
Update sdm.js
rashmiangadi05 Nov 13, 2025
5102672
UT's
rashmiangadi05 Nov 13, 2025
edbdb3b
Update sdm.js
rashmiangadi05 Nov 13, 2025
5cab6d6
Update sdm.js
rashmiangadi05 Nov 13, 2025
e69c94f
Changes
rashmiangadi05 Nov 13, 2025
cfa4b13
Changes
rashmiangadi05 Nov 13, 2025
e8175ff
Update sdm.js
rashmiangadi05 Nov 13, 2025
de90ad5
UT fix
rashmiangadi05 Nov 13, 2025
02973c7
Update index.js
rashmiangadi05 Nov 13, 2025
9a37499
Integration tests
rashmiangadi05 Nov 14, 2025
a45baf9
Merge branch 'develop' into roleerror
rashmiangadi05 Nov 14, 2025
11c8336
[Added]: Integration test for Edit Link
akshatjain-official Nov 14, 2025
4231eb8
Update attachments-sdm.test.js
rashmiangadi05 Nov 16, 2025
31d820b
Merge pull request #200 from cap-js/roleerror
rashmiangadi05 Nov 17, 2025
89b2c08
Discard Draft Integration test
akshatjain-official Nov 17, 2025
aa5c31a
Merge branch 'develop' into editLinkAutomation
akshatjain-official Nov 17, 2025
fc25b31
Bump version from 1.7.1 to 1.8.1
vibhutikumar07 Nov 17, 2025
e33e979
Merge branch 'develop' into editLinkAutomation
akshatjain-official Nov 17, 2025
d921495
Exclude DEV dependencies in Black Duck workflow
vibhutikumar07 Nov 17, 2025
3c70700
README changes for Delete issue
rashmiangadi05 Nov 21, 2025
c6082fc
Update README.md
rashmiangadi05 Nov 24, 2025
2e82963
Merge pull request #206 from cap-js/readmeupdate
rashmiangadi05 Nov 24, 2025
38bdae9
changelog
rishikunnath2747 Nov 25, 2025
3e8ca03
Merge pull request #209 from cap-js/changelog181
rishikunnath2747 Nov 25, 2025
cb38052
chore: prepare for trusted publishing, enable provenance (#202)
chgeo Nov 25, 2025
ecec81e
Update package.json
vibhutikumar07 Nov 26, 2025
0699d02
Merge branch 'develop' into gemini-fix
vibhutikumar07 Nov 28, 2025
361a7cb
Multitenant Integration tests setup
Dec 7, 2025
a6c5f5d
addressed review Comments
Dec 10, 2025
5ac9920
reverting workflow
Dec 10, 2025
9c1c0dc
formatting
Dec 10, 2025
23ce340
formatting
Dec 10, 2025
c6a4892
Merge pull request #213 from cap-js/multitenantIntegrationTestSetup
deepikaSingh2711 Dec 10, 2025
566587c
Merge branch 'develop' into gemini-fix
vibhutikumar07 Dec 11, 2025
4c6a6ec
fixed the lint issue
vibhutikumar07 Dec 11, 2025
a94e1f9
fix: remove unused catch variable to satisfy lint
vibhutikumar07 Dec 11, 2025
6c8354e
Merge pull request #197 from cap-js/gemini-fix
vibhutikumar07 Dec 11, 2025
95674c3
Add noSDMRoleUsername and noSDMRoleUserPassword to JSON
vibhutikumar07 Dec 15, 2025
9a0e6d5
Add Multi Tenancy Integration Test workflow
vibhutikumar07 Dec 15, 2025
64e1ef6
Rename integration_test.yml to Singleintegration_test.yml
vibhutikumar07 Dec 15, 2025
bcc2bb6
Fix echo statement for integration test completion
vibhutikumar07 Dec 15, 2025
9779e72
Update MultiTenantintegration_test.yml
vibhutikumar07 Dec 15, 2025
c25fdc5
added integration test as a downstream job
vibhutikumar07 Dec 15, 2025
bce6d1e
updated the workflow name
vibhutikumar07 Dec 16, 2025
b874295
Update MultiTenantintegration_test.yml
vibhutikumar07 Dec 16, 2025
638140f
[Hyperspace] 🤖 Add PR Bot Configuration
hyperspace-insights[bot] Dec 16, 2025
59f808f
Update SingleTenant_integration_test.yml
vibhutikumar07 Dec 16, 2025
816db64
Update deploy_and_Integration_test.yml
vibhutikumar07 Dec 16, 2025
b9277d0
Rename workflow to 'Single Tenant Deploy and Integration Test'
vibhutikumar07 Dec 16, 2025
05783b7
Rename workflow to include Integration Test
vibhutikumar07 Dec 16, 2025
8f82ced
Update multiTenant_deploy_and_Integration_test.yml
vibhutikumar07 Dec 16, 2025
6726e70
Update pull_request_bot.json
vibhutikumar07 Dec 16, 2025
9f32adc
Change auto_run_on_draft_pr setting to false
vibhutikumar07 Dec 16, 2025
932791f
init + uts
rishikunnath2747 Jan 1, 2026
86d6003
integration tests
rishikunnath2747 Jan 1, 2026
84ebc36
fixing uts
rishikunnath2747 Jan 2, 2026
6724a61
fix lint
rishikunnath2747 Jan 2, 2026
efbacc4
sonar fixes
rishikunnath2747 Jan 8, 2026
4801f4c
uts
rishikunnath2747 Jan 8, 2026
7e78005
Merge pull request #221 from cap-js/hardcodedatt
rishikunnath2747 Jan 9, 2026
73215f6
Merge branch 'develop' into test_singletenant
vibhutikumar07 Jan 9, 2026
5b31742
Merge branch 'develop' into pr-bot/configuration
vibhutikumar07 Jan 9, 2026
acac7da
Merge pull request #219 from cap-js/test_singletenant
rishikunnath2747 Jan 9, 2026
1877b23
Modify JSON credentials in integration test workflow
vibhutikumar07 Jan 9, 2026
5ac144b
Undefined err object
Jan 20, 2026
570582d
Cloud sdk changes
rashmiangadi05 Jan 22, 2026
b178f89
Change BlackDuck script URL in workflow
vibhutikumar07 Jan 22, 2026
fc80c4b
Unit tests
rashmiangadi05 Jan 22, 2026
c37d6f0
Changes
rashmiangadi05 Jan 22, 2026
54123cd
Update package.json
rashmiangadi05 Jan 22, 2026
9404369
coverage
rashmiangadi05 Jan 22, 2026
e0c0542
coverage
rashmiangadi05 Jan 22, 2026
1b8892c
Update sdm.js
rashmiangadi05 Jan 22, 2026
dd44111
Sonar fixes
rashmiangadi05 Jan 22, 2026
1e7d975
lint issues
rashmiangadi05 Jan 22, 2026
f458d3d
Merge pull request #227 from cap-js/errObjectFix
deepikaSingh2711 Jan 23, 2026
e732940
Merge branch 'develop' into SDMEXT-852
rashmiangadi05 Jan 23, 2026
6269186
Fixing integration tests delete call
rashmiangadi05 Jan 23, 2026
d1467d4
Update index.test.js
rashmiangadi05 Jan 23, 2026
c175970
Changes to support multitenancy
rashmiangadi05 Jan 23, 2026
99221c1
onboarding and offboarding changes
rashmiangadi05 Jan 27, 2026
b27fa79
Update server.test.js
rashmiangadi05 Jan 27, 2026
eea8fbf
Update index.js
rashmiangadi05 Jan 27, 2026
bf09fed
Update index.js
rashmiangadi05 Jan 27, 2026
ef60668
Update index.js
rashmiangadi05 Jan 27, 2026
e908dea
Update index.js
rashmiangadi05 Jan 28, 2026
f6c22df
Changes
rashmiangadi05 Jan 28, 2026
0018b72
changes
rashmiangadi05 Jan 29, 2026
4f416f4
changes
rashmiangadi05 Jan 29, 2026
27ff817
changes
rashmiangadi05 Jan 30, 2026
3ef3f37
UT changes
rashmiangadi05 Jan 30, 2026
253025d
Delete vcs.xml
rashmiangadi05 Jan 30, 2026
3c98227
Update sdm.js
rashmiangadi05 Jan 30, 2026
dc47676
Non-draft support & integration tests
yashmeet29 Jan 30, 2026
84e2875
Merge pull request #228 from cap-js/SDMEXT-852
rashmiangadi05 Feb 3, 2026
11ad0bf
Update GitHub Actions workflow for integration testing
vibhutikumar07 Feb 6, 2026
e9de7ad
Uncomment deployment steps in workflow file
vibhutikumar07 Feb 6, 2026
e17e162
Update deployment workflow to include CF login
vibhutikumar07 Feb 6, 2026
665e9c2
Refactor Cloud Foundry integration test workflow
vibhutikumar07 Feb 6, 2026
f9ab591
updated workflow
vibhutikumar07 Feb 6, 2026
736e03c
Refactor GitHub Actions workflow for deployment
vibhutikumar07 Feb 6, 2026
d132be7
Add multi-tenant deployment workflow
vibhutikumar07 Feb 6, 2026
432552b
Merge pull request #231 from cap-js/testprintegTest
vibhutikumar07 Feb 6, 2026
f207a5d
fix Setting the custom properties value to null doesn't revert the va…
akgarg06 Feb 11, 2026
158f97d
Merge branch 'develop' into pocNonDraftSupport
yashmeet29 Feb 18, 2026
0e78bc1
non-draft fixes, UTs & ITs
yashmeet29 Feb 20, 2026
ba06ea9
attachments plugin version correction
yashmeet29 Feb 20, 2026
00911c1
Update workflows to execute non-draft Integration tests
yashmeet29 Feb 20, 2026
53a77c1
lint & sonar fixes
yashmeet29 Feb 20, 2026
9b11f30
sonar fix
yashmeet29 Feb 20, 2026
b424209
changelog 1.8.2
Feb 20, 2026
3ff5e35
Merge pull request #234 from cap-js/changelog
yashmeet29 Feb 20, 2026
dd87c11
Merge branch 'develop' into supportForNonDraftScenarios
yashmeet29 Feb 23, 2026
673af28
Fix [NodeJs] Incorrect Warning message if a user without SDM Roles up…
akgarg06 Feb 23, 2026
2a37a29
Merge branch 'develop' into DINC0721168
akgarg06 Feb 23, 2026
b5f2001
remove comment
yashmeet29 Feb 24, 2026
9cee4d8
Merge branch 'supportForNonDraftScenarios' of https://github.com/cap-…
yashmeet29 Feb 24, 2026
eb7b0d4
Merge pull request #233 from cap-js/supportForNonDraftScenarios
yashmeet29 Feb 24, 2026
6dd9527
Merge branch 'develop' into DINC0711541
akgarg06 Feb 24, 2026
d57906c
ReadMe Update & Update non-draft integration test to use .xlsx instea…
yashmeet29 Feb 24, 2026
52c0885
lint fix
yashmeet29 Feb 24, 2026
bed12de
Update deploy_and_Integration_test.yml
vibhutikumar07 Feb 25, 2026
6543efc
Merge branch 'develop' into pr-bot/configuration
vibhutikumar07 Feb 25, 2026
39182f3
Merge pull request #220 from cap-js/pr-bot/configuration
vibhutikumar07 Feb 25, 2026
41b247f
Merge branch 'develop' into DINC0711541
akgarg06 Feb 26, 2026
387fa9a
Update index.js
akgarg06 Feb 26, 2026
08955e7
Merge branch 'DINC0711541' of https://github.com/cap-js/sdm into DINC…
akgarg06 Feb 26, 2026
f5845a4
Update index.js
akgarg06 Feb 26, 2026
e690556
Merge pull request #235 from cap-js/DINC0711541
akgarg06 Feb 26, 2026
12f8f79
Merge branch 'develop' into DINC0721168
akgarg06 Feb 26, 2026
8fbcce8
Merge pull request #232 from cap-js/DINC0721168
akgarg06 Feb 26, 2026
874fef3
fix for draft edit link
Mar 10, 2026
f89fbe0
Merge pull request #237 from cap-js/editLinkDraftFix
yashmeet29 Mar 13, 2026
49a2798
Merge branch 'develop' into editLinkAutomation
deepikaSingh2711 Mar 13, 2026
40303b2
change
Mar 13, 2026
04f21c6
error msg for nosdm role
Mar 13, 2026
1fe121c
added edit link automation testcase
Mar 13, 2026
b239ffb
added validation for blocked mime types
Mar 13, 2026
4f4b3f3
added unit test
Mar 13, 2026
559e6ba
fixed UT
Mar 13, 2026
6ba8b90
Merge pull request #203 from cap-js/editLinkAutomation
deepikaSingh2711 Mar 13, 2026
ec9c036
Change Log for Release 1.9.0 & an error message fix in Integration test
yashmeet29 Mar 18, 2026
d5eac6b
Merge pull request #238 from cap-js/changeLogForRel1.9.0
yashmeet29 Mar 18, 2026
3c61831
bugfix_compostion_not_found_wrong_namespace
goeblj Mar 27, 2026
b92db3a
test
goeblj Apr 1, 2026
2cd74bd
merge upstream 1.9.1
goeblj Apr 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sdm.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ let subdomain = cds.context?.user?.authInfo?.token?.payload?.ext_attr?.zdn;
for (const [elementName, element] of Object.entries(entityDef.elements)) {
if (element.type === 'cds.Composition' && element.target) {
const targetDef = cds.model.definitions[element.target];
if (targetDef && targetDef.includes && targetDef.includes.includes('sap.attachments.Attachments')) {
if (targetDef && targetDef.includes && (targetDef.includes.includes('sap.attachments.Attachments') || targetDef.includes.includes('Attachments'))) {
attachmentCompositions.push(elementName);
}
}
Expand Down
51 changes: 51 additions & 0 deletions test/lib/sdm.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5102,6 +5102,57 @@ describe("SDMAttachmentsService", () => {
expect(result).toEqual([compositionName]);
});
});

it('should recognize Attachments without namespace prefix', () => {
const targetEntity = { name: 'Test.EntityWithShortAttachments' };

cds.model.definitions['Test.EntityWithShortAttachments'] = {
elements: {
attachments: {
type: 'cds.Composition',
target: 'Test.ShortAttachments'
}
}
};

cds.model.definitions['Test.ShortAttachments'] = {
includes: ['Attachments'] // Without 'sap.attachments.' prefix
};

const result = service.getAttachmentCompositions(targetEntity);

expect(result).toEqual(['attachments']);
});

it('should recognize both full and short Attachments includes', () => {
const targetEntity = { name: 'Test.EntityWithMixedIncludes' };

cds.model.definitions['Test.EntityWithMixedIncludes'] = {
elements: {
fullAttachments: {
type: 'cds.Composition',
target: 'Test.FullAttachments'
},
shortAttachments: {
type: 'cds.Composition',
target: 'Test.ShortAttachments'
}
}
};

cds.model.definitions['Test.FullAttachments'] = {
includes: ['sap.attachments.Attachments']
};
cds.model.definitions['Test.ShortAttachments'] = {
includes: ['Attachments']
};

const result = service.getAttachmentCompositions(targetEntity);

expect(result).toContain('fullAttachments');
expect(result).toContain('shortAttachments');
expect(result.length).toBe(2);
});
});

describe('replacePropertiesInAttachment', () => {
Expand Down