Skip to content

fix: Honor @mandatory annotation#155

Merged
daogrady merged 2 commits into
mainfrom
fix/mandatory
Jun 10, 2026
Merged

fix: Honor @mandatory annotation#155
daogrady merged 2 commits into
mainfrom
fix/mandatory

Conversation

@daogrady

@daogrady daogrady commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #147

@daogrady daogrady requested a review from tim-sh June 8, 2026 07:33
@daogrady daogrady changed the title Honor annotation fix: Honor @mandatory annotation Jun 8, 2026

@tim-sh tim-sh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small findings

Comment thread lib/compile/index.js
Comment thread lib/compile/index.js
@tim-sh tim-sh self-requested a review June 10, 2026 10:28
@daogrady daogrady merged commit aacb6f6 into main Jun 10, 2026
9 checks passed
@daogrady daogrady deleted the fix/mandatory branch June 10, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] @mandatory annotation on function parameters causes "Unexpected mandatory after optional parameter" error

2 participants