Conversation
There was a problem hiding this comment.
The PR makes two configuration changes to prepare for CDS 9/10: bumping the peer dependency floor from >=8 to >=9, and renaming the outbox queue setting to queue. Both changes are functionally straightforward, but the outbox→queue rename is a silent breaking change for existing consumers with no changelog entry or migration path, and the CDS 8 compatibility dead code should be cleaned up alongside the peer dep bump.
PR Bot Information
Version: 1.22.9
- Event Trigger:
pull_request.opened - File Content Strategy: Full file content
- Correlation ID:
f46a17c8-b3b9-46d1-bb2a-96ece60109b1 - LLM:
anthropic--claude-4.6-sonnet
| }, | ||
| "peerDependencies": { | ||
| "@sap/cds": ">=8" | ||
| "@sap/cds": ">=9" |
There was a problem hiding this comment.
Best Practices: CDS 8 fallback code is now dead code after dropping >=8 peer dependency
The peer dependency floor was raised to >=9, but lib/plugin.js still contains a CDS 8 fallback branch (cds.version >= "8.6.0" ? "compile.to.edmx" : "loaded" on line 18) and lib/generic-handlers.js still has a // CAP 8 fallback comment block around the inferTargetCAP8 helper. With @sap/cds >=9 enforced, these branches are unreachable and should be removed to avoid confusion and maintenance burden.
Consider cleaning up the CDS 8 compatibility shims now that support is officially dropped.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
| }, | ||
| "attachments": { | ||
| "outbox": true, | ||
| "queue": true, |
There was a problem hiding this comment.
Best Practices: Breaking configuration rename is not documented in CHANGELOG.md
Renaming outbox: true to queue: true in the default cds.requires.attachments config is a breaking change for any consumer who has explicitly set attachments.outbox: true in their own project's cds configuration — their value will now be silently ignored.
No entry for this rename appears in CHANGELOG.md. Consider:
- Adding a changelog entry under a new version that calls this out as a breaking change.
- Adding a migration hint or deprecation warning in the runtime when the old
outboxkey is detected, e.g.:
if (cds.env.requires.attachments?.outbox !== undefined) {
LOG.warn('`cds.requires.attachments.outbox` is deprecated; use `queue` instead.')
}Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
Prepare for CDS 10 Compatibility
Chore
🔧 Updates the
@cap-js/attachmentspackage configuration to be compatible with the upcoming CDS 10 release by bumping the minimum peer dependency version and updating an API configuration key.Changes
package.json:peerDependenciesminimum version for@sap/cdsfrom>=8to>=9.outboxconfiguration key toqueueunder theattachmentsservice configuration, reflecting a CDS API change.PR Bot Information
Version:
1.22.9f46a17c8-b3b9-46d1-bb2a-96ece60109b1anthropic--claude-4.6-sonnetpull_request.opened