Update the log checker to reduce disk use and to check canton logs#6174
Merged
Conversation
nicu-da
changed the title
nicu-da
changed the title
martinflorian-da
approved these changes
Jul 1, 2026
martinflorian-da
left a comment
martinflorian-da
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable, thank you!
Would make a pass to cut words in the comments but don't mind it all that much either. 🤖
| sed -n "0,/$SHUTDOWN_MESSAGE_PATTERN/p" "$LOGFILE" >> "$LOGFILE_BEFORE" | ||
| # Find the line number of the shutdown message (first and only match). | ||
| # This avoids ever making a second copy of the (potentially large) "before" | ||
| # half of the log file. The previous approach wrote both halves out with sed |
Contributor
There was a problem hiding this comment.
nit: consider making this a bit less verbose
Contributor
Author
There was a problem hiding this comment.
I considered that but I am weary of us changing in the future without looking at it closely, so would just leave the entire 🤖 story
…files [ci] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
[ci] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
[ci] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
nicu-da
force-pushed
the
nicu/chore/smarter_log_split
branch
from
4a0a80b to
833cec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…files
the fun part is that the canton log checking was broken because of a \n in the ignore patterns, and a
|| trueon the rg command[ci]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines