Fill in missing KMS Driver API v1 interface#898
Open
8bitpal wants to merge 2 commits into
Open
Conversation
The v1.KmsDriver code block was a stub (trait KmsDriver with no body). Replaced with verbatim content from community/kms-driver-api/src/main/scala/.../v1/KmsDriver.scala in the canton repo. Closes #785 Signed-off-by: 8bitpal <eliashaase@gmail.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
|
@8bitpal can we use snippets for this to run some linting on the code snippet, since it is significant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
### KMS Driver API v1section contained only a stub (trait KmsDriverwith no body). Replaced with verbatim content copied fromcommunity/kms-driver-api/src/main/scala/com/digitalasset/canton/crypto/kms/driver/api/v1/KmsDriver.scalain the canton repo.The upstream RST source (
kms_driver_guide.rst) also has the stub, that's a separate upstream fix. This brings the hosted docs in line with the actual API.Closes #785