Minor formatting updates

Author: sveinse

canopen/pdo/base.py

@@ -456,7 +456,6 @@ def save_generator(self):
                 # fixed number of entries (count not writable), generate dummy
                 # mappings for an invalid object 0x0000:00 to overwrite any
                 # excess entries with all-zeros.
-
                 self._fill_map(self.map_array[0].get_raw())  # FIXME: Blocking?
             subindex = 1
             for var in self.map:

canopen/profiles/p402.py

@@ -370,7 +370,7 @@ def homing(self, timeout=None, restore_op_mode=False):
 
     @property
     def op_mode(self):
-        logger.warning("Accessing BaseNode402.op_mode property is deprecated")
+        logger.warning("Accessing BaseNode402.op_mode property is deprecated, use get_op_mode()")
         return self.get_op_mode()
 
     def get_op_mode(self):
@@ -456,7 +456,7 @@ def is_op_mode_supported(self, mode):
         """
         if not hasattr(self, '_op_mode_support'):
             # Cache value only on first lookup, this object should never change.
-            self._op_mode_support = self.sdo[0x6502].get_raw()
+            self._op_mode_support = self.sdo[0x6502].get_raw()  # FIXME: Blocking
             logger.info('Caching node {n} supported operation modes 0x{m:04X}'.format(
                 n=self.id, m=self._op_mode_support))
         bits = OperationMode.SUPPORTED[mode]
@@ -475,7 +475,7 @@ def on_TPDOs_update_callback(self, mapobject):
 
     @property
     def statusword(self):
-        logger.warning("Accessing BaseNode402.statusword property is deprecated")
+        logger.warning("Accessing BaseNode402.statusword property is deprecated, use get_statusword()")
         return self.get_statusword()
 
     def get_statusword(self):
@@ -537,7 +537,7 @@ def set_controlword(self, value):
 
     @property
     def state(self):
-        logger.warning("Accessing BaseNode402.state property is deprecated")
+        logger.warning("Accessing BaseNode402.state property is deprecated, use get_state()")
         return self.get_state(self)
 
     def get_state(self):

canopen/variable.py

@@ -26,6 +26,7 @@ def __init__(self, od: objectdictionary.Variable):
         self.subindex = od.subindex
 
     def get_data(self) -> bytes:
+        """Byte representation of the object as :class:`bytes`."""
         raise NotImplementedError("Variable is not readable")
 
     async def aget_data(self) -> bytes:
@@ -39,8 +40,7 @@ async def aset_data(self, data: bytes):
 
     @property
     def data(self) -> bytes:
-        """Byte representation of the object as :class:`bytes`."""
-        logger.warning("Accessing Variable.data property is deprecated")
+        logger.warning("Accessing Variable.data property is deprecated, use get_data()")
         return self.get_data()
 
     @data.setter
@@ -50,7 +50,7 @@ def data(self, data: bytes):
 
     @property
     def raw(self) -> Union[int, bool, float, str, bytes]:
-        logger.warning("Accessing Variable.raw property is deprecated")
+        logger.warning("Accessing Variable.raw property is deprecated, use get_raw()")
         return self.get_raw()
 
     def get_raw(self) -> Union[int, bool, float, str, bytes]:
@@ -119,7 +119,7 @@ def _set_raw(self, value: Union[int, bool, float, str, bytes]):
 
     @property
     def phys(self) -> Union[int, bool, float, str, bytes]:
-        logger.warning("Accessing Variable.phys attribute is deprecated")
+        logger.warning("Accessing Variable.phys attribute is deprecated, use get_phys()")
         return self.get_phys()
 
     def get_phys(self) -> Union[int, bool, float, str, bytes]:
@@ -153,11 +153,11 @@ async def aset_phys(self, value: Union[int, bool, float, str, bytes]):
 
     @property
     def desc(self) -> str:
-        """Converts to and from a description of the value as a string."""
-        logger.warning("Accessing Variable.desc attribute is deprecated")
+        logger.warning("Accessing Variable.desc attribute is deprecated, use get_desc()")
         return self.get_desc()
 
     def get_desc(self) -> str:
+        """Converts to and from a description of the value as a string."""
         value = self.od.decode_desc(self.get_raw())
         logger.debug("Description is '%s'", value)
         return value
@@ -180,8 +180,11 @@ async def aset_desc(self, desc: str):
 
     @property
     def bits(self) -> "Bits":
-        """Access bits using integers, slices, or bit descriptions."""
         logger.warning("Accessing Variable.bits attribute is deprecated")
+        return self.get_bits()
+
+    def get_bits(self) -> "Bits":
+        """Access bits using integers, slices, or bit descriptions."""
         return Bits(self)
 
     def read(self, fmt: str = "raw") -> Union[int, bool, float, str, bytes]: