Skip to content

fix validation rc Sync26#235

Open
bigludo7 wants to merge 6 commits into
mainfrom
fix231
Open

fix validation rc Sync26#235
bigludo7 wants to merge 6 commits into
mainfrom
fix231

Conversation

@bigludo7

@bigludo7 bigludo7 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Updated references to common components and added request body strictness section.

What type of PR is this?

Add one of the following kinds:

  • correction
  • documentation
  • subproject management

What this PR does / why we need it:

  • Adapts number verification APIs to CAMARA Commonalities r4.3 / 0.8.0 (Sync26), aligning schemas, responses, parameters and info.description structure with CAMARA_common.yaml.

  • Added mandatory info.description markers (authorization-and-authentication, additional-error-responses, request-body-strictness)

  • Replaced local schemas with $ref to CAMARA_common.yaml: ErrorInfo

  • Replaced Generic400 and Generic401 local responses with $ref to CAMARA_common.yaml

  • Updated ErrorInfo refs in PhoneNumberVerificationPermissionDenied403

  • Deleted obsolete number-verfication-API-Readiness-Checklist.md

Which issue(s) this PR fixes:

Fixes #231

Special notes for reviewers:

All changes are non-breaking
Schema substitutions use $ref pointing to ../common/CAMARA_common.yaml (Commonalities r4.3 / 0.8.0).

Changelog input

release-note: Sync with CAMARA Commonalities r4.3 / 0.8.0 (Sync26): align schemas, responses, parameters and info.description mandatory markers)

Additional documentation

This section can be blank.

docs

bigludo7 added 2 commits June 16, 2026 14:45
Updated references to common components and added request body strictness section.
@camara-validation

camara-validation Bot commented Jun 16, 2026

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

@bigludo7

Copy link
Copy Markdown
Collaborator Author

@fernandopradocabrillo @AxelNennker : PR ready to be review & approved
Aligned with Commonalities r4.3
cc: @hdamker

Comment thread code/API_definitions/number-verification.yaml Outdated
Comment thread code/API_definitions/number-verification.yaml Outdated
@hdamker

hdamker commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@bigludo7 I fixed with 8fa341f and 4fbb32b the last remaining hint. Reviewing now the rest.

@hdamker hdamker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... the only possible addition would be:

For a non-composed request body, Commonalities Design Guide §2.3 says the spec SHOULD declare additionalProperties: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply Commonalities 0.8.0 enhancements for Number Verification

3 participants