Skip to content

Add additional newline after SGML comments so that Swagger editor displays markdown header properly#652

Open
eric-murray wants to merge 1 commit into
camaraproject:mainfrom
eric-murray:eric-murray-patch-4
Open

Add additional newline after SGML comments so that Swagger editor displays markdown header properly#652
eric-murray wants to merge 1 commit into
camaraproject:mainfrom
eric-murray:eric-murray-patch-4

Conversation

@eric-murray

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • correction

What this PR does / why we need it:

The swagger editor is ignoring the markdown header directive that immediately follows SGML comments: e.g.

<!-- CAMARA:MANDATORY:authorization-and-authentication:BEGIN -->
# Authorization and authentication

The solution is to add an additional newline following the comment. e.g.:

<!-- CAMARA:MANDATORY:authorization-and-authentication:BEGIN -->

# Authorization and authentication

Which issue(s) this PR fixes:

Fixes #651

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Redoc viewer is unaffected by this

Changelog input

 release-note
 - Add additional newline after SGML comments so that Swagger editor displays markdown header properly

Additional documentation

None

@tlohmar tlohmar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I thought that I accidentally removed these empty lines and already inserted them.

@PedroDiez PedroDiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown immediately after SGML comment is not displayed properly by Swagger editor

3 participants