Define common Sink schema to be used by API templates#646
Open
eric-murray wants to merge 6 commits into
Open
Conversation
eric-murray
requested review from
PedroDiez,
bigludo7,
jlurien and
rartych
as code owners
PedroDiez
reviewed
Jun 18, 2026
PedroDiez
reviewed
Jun 18, 2026
PedroDiez
left a comment
PedroDiez
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Good point to apply this simplification in the templates it will also help API initiatives for doing alignment work
Minor comment in case we think could be better to consider
(For the record anyway in case we keep as is, as a way to customize descriptions when needed)
Collaborator
Author
|
I updated the proposal to keep the sink description that is currently in the templates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The API templates repeat the definition of the
sinkproperty. By defining a common schema, this duplication can be avoided.Which issue(s) this PR fixes:
Fixes #647
Does this PR introduce a breaking change?
Special notes for reviewers:
None
Changelog input
Additional documentation
None