Skip to content

feat: polish replay test progress reporter#998

Merged
thymikee merged 4 commits into
mainfrom
feat/replay-test-progress-reporter
Jul 1, 2026
Merged

feat: polish replay test progress reporter#998
thymikee merged 4 commits into
mainfrom
feat/replay-test-progress-reporter

Conversation

@thymikee

@thymikee thymikee commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

Improve live replay test progress output with an animated blue spinner, action/value detail, ANSI-safe trimming, cursor hiding during TTY test runs, and a shared Expo build cache path for the test app.

Add a title to the checkout Maestro flow so reporter output uses a readable flow name.

Validation

Focused reporter tests pass for live progress rendering and cursor control. Static checks pass, and the aggregate unit plus smoke suite passed.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.5 MB 1.5 MB +1.9 kB
JS gzip 469.9 kB 470.7 kB +762 B
npm tarball 572.1 kB 572.9 kB +787 B
npm unpacked 2.0 MB 2.0 MB +2.0 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.4 ms 26.6 ms +0.2 ms
CLI --help 46.5 ms 46.6 ms +0.1 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/cli.js +1.3 kB +578 B
dist/src/session.js +619 B +184 B

@thymikee thymikee force-pushed the feat/replay-test-progress-reporter branch from bfcd98c to b40ece2 Compare July 1, 2026 12:21
@thymikee

thymikee commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

CI is blocked on the same unit failure in both Unit Tests and Coverage:

  • src/replay/test/tests/reporters-default.test.ts > default replay test reporter hides and restores cursor for tty progress
  • Assertion at line 54 expected stderr[0] to be the cursor-hide escape sequence, but it was undefined.

Please address the reporter/test mismatch and rerun checks; smoke jobs were still pending when I checked.

@thymikee

thymikee commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Review finding:

examples/test-app/app.json now hardcodes ~/Developer/agent-device/.expo/build-run-cache as the Expo build cache directory. That path is specific to one checkout layout and will also be shared by every worktree on the same machine, which breaks the repo/worktree isolation we rely on for concurrent agent runs. It also points contributors/CI checkouts that are not under ~/Developer/agent-device at an unrelated home directory path.

Please make this cache path repo-relative/worktree-local by default, or opt-in through an env/local config that is not committed into the shared example app config.

@thymikee

thymikee commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Review follow-up: the previous cache-path blocker is resolved in head 3ae8811. The hardcoded home-directory path was removed with app.json replaced by app.config.js, defaulting AGENT_DEVICE_EXPO_BUILD_CACHE_DIR to a repo-local ./.expo/build-run-cache and ignoring examples/test-app/.env.local. I rechecked the targeted diff and all 21 checks are green, so I am marking this ready for human review.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Jul 1, 2026
@thymikee thymikee merged commit 4cd40aa into main Jul 1, 2026
21 checks passed
@thymikee thymikee deleted the feat/replay-test-progress-reporter branch July 1, 2026 14:21
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-01 14:22 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant