docs: distinguish removed request-count CI gate from restored cost.runnerRoundTrips (Phase 3 plan)#971
Merged
Merged
Conversation
…n Phase 3 plan The Step (c) request-count bullet claimed both the dev-only CI gate AND the runtime `cost.runnerRoundTrips` surface were removed in #968. #970 restored the public agent-cost field, so the bullet is stale/misleading for the next Apple/agent-cost worker. Split the bullet: the dev-only request-count CI gate (the #966 --debug ndjson counter + smoke-ios assertion) stays removed (zero runner events on main runs); the runtime `cost.runnerRoundTrips` agent-cost field (ResponseCost / buildResponseCost over RUNNER_ROUND_TRIP_PHASES) is a separate pre-existing surface, restored in #970, and remains part of the agent-cost contract.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
Review pass for head d871843 found no actionable blockers. This directly resolves the stale Phase 3 plan note left by #970: it distinguishes the removed dev-only request-count CI gate from the restored public cost.runnerRoundTrips agent-cost field, and the referenced runtime locations match #970. Docs-only change; all reported checks are green. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plans/phase3-platform-plugin-progress.mdStep (c) bullet 4 said both the runner request-count CI gate and thecost.runnerRoundTripsruntime surface were removed in #968. #970 intentionally restored the public agent-cost field, so the bullet is now stale/misleading for the next Apple/agent-cost worker.This splits the bullet to distinguish the two:
--debugndjson counter +smoke-iosassertion) — stays removed (successfulmainruns captured zero runner events, so the signal did not prove runner behavior).cost.runnerRoundTripsagent-cost field (ResponseCostinsrc/kernel/contracts.ts; computed bybuildResponseCostoverRUNNER_ROUND_TRIP_PHASESinsrc/daemon/request-router.ts) — a separate, pre-existing surface, briefly dropped alongside the gate but restored in fix: restore runnerRoundTrips agent-cost field dropped in #968 #970, and it remains part of the agent-cost contract.Docs-only (plan file). No code change.