fix: capture ios device logs with devicectl console#1026
Open
thymikee wants to merge 6 commits into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
2d6dfe0 to
5eda037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture iOS physical-device app output by launching the session app through
xcrun devicectl device process launch --console --terminate-existing, avoiding the rejecteddevice log stream --devicepath on devicectl 506.6.Keep the clear unsupported fallback only for toolchains that do not expose console capture, and report that capability in
logs doctor.logs path/logs doctorstill surface failed startup state instead of letting marker-only logs look active.Closes #1022
Validation
Passed local checks:
pnpm exec vitest run src/daemon/__tests__/app-log.test.ts src/daemon/handlers/__tests__/session.test.ts src/utils/__tests__/args.test.ts --testNamePattern "logs clear --restart starts active|logs clear --restart requires|runAppLogDoctor|startIosDeviceAppLog|buildIosDeviceConsole|usageForCommand resolves debugging";pnpm format;pnpm check:quick;pnpm check:fallow --base origin/main;pnpm check:unit;pnpm build.Physical-device verification used
thymikee-iphone/ UDID00008150-001849640CF8401C. I ranpnpm test-app:start -- --port 8081, kept Expo/Metro visible, then openedcom.callstack.agentdevicelabwith sessionissue-1022-console-logs.logs clear --restart,logs mark,logs path, andlogs doctorshowed an activeios-devicebackend withdevicectlAvailable: trueanddevicectlConsoleCapture: true; the boundedapp.logwindow contained real app output including the Metro bundle request andReactInstance: evaluateJavaScript() with JS bundle, not only marker entries.snapshot -ion the same session showed theAgent Device TesterRN home screen.Manual cleanup: closed
issue-1022-console-logsand stopped the Expo process.