Skip to content

fix(chat): minimal tool-call styling + breathing room before downstream content #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
May 13, 2026
+28 −10
Merged

fix(chat): minimal tool-call styling + breathing room before downstream content #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions libs/chat/src/lib/compositions/chat-tool-call-card/chat-tool-call-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,27 @@ export interface ToolCallInfo {
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [CHAT_HOST_TOKENS, `
:host { display: block; }
.tcc__name { font-family: var(--ngaf-chat-font-mono); color: var(--ngaf-chat-text); }
.tcc__name {
font-family: var(--ngaf-chat-font-mono);
font-size: var(--ngaf-chat-font-size-sm, 13px);
color: var(--ngaf-chat-text-muted);
font-weight: 400;
padding-left: 2px;
}
.tcc__pill {
display: inline-flex;
align-items: center;
gap: 4px;
padding: 1px 7px;
gap: 3px;
padding: 1px 6px;
border-radius: 9999px;
background: var(--ngaf-chat-surface-alt);
color: var(--ngaf-chat-text-muted);
font-size: 11px;
font-weight: 600;
font-size: 10px;
font-weight: 500;
margin-left: 6px;
line-height: 1.4;
}
.tcc__pill[data-status="complete"] { color: var(--ngaf-chat-success); }
.tcc__pill[data-status="error"] { color: var(--ngaf-chat-error-text); }
.tcc__pill svg { width: 11px; height: 11px; }
.tcc__pill svg { width: 10px; height: 10px; }
.tcc__pill[data-status="running"] svg { animation: tcc-spin 0.8s linear infinite; }
@keyframes tcc-spin { to { transform: rotate(360deg); } }
.tcc__section { padding: 8px 0; }
Expand Down
14 changes: 14 additions & 0 deletions libs/chat/src/lib/primitives/chat-tool-calls/chat-tool-calls.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,3 +312,17 @@ describe('ChatToolCallsComponent — excludeToolNames filter', () => {
expect(text).not.toContain('research');
});
});

describe('ChatToolCallsComponent — breathing room before downstream content', () => {
it('host has bottom margin >= 16px so the next sibling gets clear separation', () => {
TestBed.configureTestingModule({ imports: [FilterHost] });
const fx = TestBed.createComponent(FilterHost);
fx.detectChanges();
const host = fx.nativeElement.querySelector('chat-tool-calls') as HTMLElement;
document.body.appendChild(host);
const computed = getComputedStyle(host);
const marginBottom = parseFloat(computed.marginBottom || '0');
expect(marginBottom).toBeGreaterThanOrEqual(16);
document.body.removeChild(host);
});
});
4 changes: 2 additions & 2 deletions libs/chat/src/lib/primitives/chat-tool-calls/chat-tool-calls.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ interface Group {
imports: [NgTemplateOutlet, ChatToolCallCardComponent],
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [`
:host { display: block; }
:host { display: block; margin-bottom: 20px; }
.ctc__group {
border: 1px solid var(--ngaf-chat-separator);
border-radius: var(--ngaf-chat-radius-card);
margin: 0 0 8px;
margin: 0 0 4px;
}
.ctc__group-header {
display: flex;
Expand Down
Loading