Skip to content

Skip {types-,}protobuf upgrades in Renovate #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanvanburen merged 2 commits into from
Apr 13, 2026
Merged

Skip {types-,}protobuf upgrades in Renovate #452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
450f322
Skip {types-,}protobuf upgrades in Renovate
stefanvanburen Apr 10, 2026
426da3d
Disable entirely
stefanvanburen Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,17 @@
// when necessary.
"enabled": false
},
{
"matchCategories": ["python"],
"matchPackageNames": [
"protobuf",
"types-protobuf"
],
// We manage these dependencies ourselves.
"lockFileMaintenance": {
Copy link
Copy Markdown

@anuraaga anuraaga Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this so just any type of update is disabled for them, in case we add to a subproject some day

Copy link
Copy Markdown
Member Author

@stefanvanburen stefanvanburen Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean going from:

      "lockFileMaintenance": {
        "enabled": false
      }

to:

      "enabled": false

?

I'm still a tad confused by the comment here (and in connect-python) about only bumping prod dependencies when necessary, but matching both prod and "optional" dependencies?: https://github.com/connectrpc/connect-python/blob/f188e7d0452be8a1ad04e308754852c76ee62c4d/renovate.json#L16-L23

Copy link
Copy Markdown

@anuraaga anuraaga Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's what I meant. One point is the enablement is a setting, while the others are matchers. So the setting to "disable all updates for the matched dependencies" is the plain enabled: false IIUC.

The optional dependencies point is admittedly cargo culted from some templates. In a hypothetical future where we supported extras in any of the libraries, those would be in optional-dependencies and would be the same scheme as production dependencies. Since we don't have any, indeed it's confusing - maybe it's better to remove that and add it when/if the time comes.

Copy link
Copy Markdown
Member Author

@stefanvanburen stefanvanburen Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

426da3d. thanks for explaining; that makes more sense to me.

"enabled": false
}
},
{
"matchCategories": [
"python"
Expand Down
Loading