Open
Conversation
- remove grunt - remove kss and docs (for now) - implement webpack build in use on child theme starter and plugin starter
- remove kss - revert src folder and other deletions - change build destination back to dist
…s without any CSS that is printed to avoid duplication of styles
…y want included once in the final compiled stylesheet
…ables, mixins, etc
I didn’t want to completely change this, just get what we had working again. - move polyfills to separate file that is imported - move `bu_blocks` global object to separate partial `blocks-frontend-tools.js` that can be imported into each frontend.js file so each block can store it’s functions on the single `bu_blocks` object attached to the window. The polyfills file might not be needed anymore. For one the browser support is better than 2019 so they might be irrelevant polyfills, but also in the old build process there was no browserify or similar performing any JS processing and automatically adding polyfills. Webpack may be doing that as part of the build and that needs to be researched.
This should be okay since the registered handles for each script/style remain the same but may need testing. Some custom themes are removing these styles but that should still work if it was done by referencing the registered handle.
* build without errors * npm run build * testing new build - remove grunt - remove kss and docs (for now) - implement webpack build in use on child theme starter and plugin starter * breaking it - remove kss - revert src folder and other deletions - change build destination back to dist * update composer.json name
… into build/update-scss
# Conflicts: # composer.json # dev/version.js # dist/bu-blocks-frontend.js # languages/bu-blocks.pot # package-lock.json # package.json # src/blocks.js # src/style.scss # webpack.plugin.js
Build/update scss
…apsible-block-generated-anchors-issues # Conflicts: # dist/blocks.build.js
…enter space characters on a button element
…sn’t change title, etc. Adding the autoID to the useEffect array causes useEffect to monitor for a change in the autoID setting
…enerated-anchors-issues Bug/355 wp5.8 collapsible block generated anchors issues
Co-authored-by: Dakota Chichester <acketon@gmail.com>
* lint js and php - remove tests folder - remove slideshow block (incomplete, can be added as a feature later, should not be in production at this time) * eslint and prettier - remove hbs files
… to `clip-path` outputs the attribute on the frontend as expected.
…r, remove 4.9 fallback code
…e for inserter, remove 4.9 fallback code
…5.8. Also additional modernization updates where possible.
…pts-203 Fix bugs in WordPress 5.8 related to withColors and modernize code in blocks
…allbacks Dakota/remove object fit images fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.