Expose num_to_roughnum from runtime#1393
Merged
jpolitz merged 1 commit intobrownplt:horizonfrom Oct 14, 2019
Merged
Conversation
Member
|
This is fine to expose and makes sense to have it conveniently on runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
num_to_roughnumfunction on the Pyret runtime.This function is heavily used in the TensorFlow addition (see brownplt/code.pyret.org#287), but should be relatively easy to swap out if there are better alternatives. There might be a better way to create Roughnums from a JavaScript library that I'm missing, so let me know if this is unnecessary.