Portfolio: Enhancement - Consolidate portfolio worklet runtimes to reduce RAM usage#2176
Closed
cmgustavo wants to merge 1 commit into
Closed
Portfolio: Enhancement - Consolidate portfolio worklet runtimes to reduce RAM usage#2176cmgustavo wants to merge 1 commit into
cmgustavo wants to merge 1 commit into
Conversation
Member
Author
Memory Pressure:
Private Dirty:
The fix saves ~29–38 MB, that is not sufficient to prevent the WatchdogTermination. iOS crashes the app at roughly 1.2–1.5 GB on iPhone 11 Pro. So, PR is not solving current issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace three separate WorkletRuntime instances (main, rates, analysis) with a single shared runtime.
Also fixes resetPortfolioRuntimeClient which was not resetting the main runtime reference.