CreateAccount: Fix - Use crypto.randomBytes for salt generation#2175
Open
cmgustavo wants to merge 1 commit into
Open
CreateAccount: Fix - Use crypto.randomBytes for salt generation#2175cmgustavo wants to merge 1 commit into
cmgustavo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace PBKDF2-based salt generation with crypto.randomBytes, consistent with the approach already used in
pin.ts.The previous implementation could pass 0 iterations to pbkdf2Sync and blocked the JS thread unnecessarily. This PR doesn't affect current users.